| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Ideally we would reread /run/gdm/custom.conf after we've decided
graphics setup is complete. This is because the file may not
get written out by udev until after GDM is already started and waiting.
As a first step to get there, this commit adds an API for rereading
the file, and changes the SIGHUP handler to use it (instead of
the complete teardown and reinitialization it was doing before).
|
|
|
|
|
|
|
|
|
|
|
| |
When using unknown command line options with the GDM daemon, the
program hangs until explicitly getting killed.
This commit addresses that bug by dropping an unnecessary call to
g_option_context_set_ignore_unknown_options, so GOptionContext will
now give an error when encountering unknown options.
https://bugzilla.gnome.org/show_bug.cgi?id=795494
|
|
|
|
|
|
|
|
|
| |
Use EXIT_ defines for readibility.
There were some exit codes > 1, but they don't seem to be checked by any of the
parent process code. This does mean that the logs might have changed, but
modern logging techniques have probably made this obsolete.
https://bugzilla.gnome.org/show_bug.cgi?id=788307
|
|
|
|
|
|
|
|
|
| |
Remove goto that no longer does anything.
Consistently use return instead of exit() from main.
Print pre-log errors to stderr to ensure they're visible regardless of GLib
settings.
https://bugzilla.gnome.org/show_bug.cgi?id=788302
|
|
|
|
|
|
|
| |
The root check doesn't require settings and may be the cause of settings
failing to load.
https://bugzilla.gnome.org/show_bug.cgi?id=788301
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=788300
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=788299
|
|
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
https://bugzilla.gnome.org/show_bug.cgi?id=772203
|
|
|
|
|
|
|
|
|
| |
The file is not anymore useful than a boolean on the manager
state object now, that everything is merged into one process.
This commit gets rid of it, since a boolean is simpler.
https://bugzilla.gnome.org/show_bug.cgi?id=746492
|
|
|
|
|
|
|
|
| |
Get the ShowLocalGreeter option from configuration file BEFORE launching
the gdm manager. In order to let the manager know if it have to launch a
local X server or not.
https://bugzilla.gnome.org/show_bug.cgi?id=743440
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the slave is removed as a separate process, it means that we need
to be more careful with our handling of SIGUSR1. If multiple X servers
are launched at once, we need to use siginfo_t to get the PID of the
thing that sent the user signal, and make sure we signal the correct
GdmServer.
glib doesn't have native siginfo support, so do it ourselves by using
a worker thread that spins around waiting for sigwaitinfo.
https://bugzilla.gnome.org/show_bug.cgi?id=724382
|
|
|
|
|
|
|
|
| |
Trying to integrate the slave into the main daemon means that we
need to respond to USR1 as it's the signal Xorg sends when the
X server is ready.
https://bugzilla.gnome.org/show_bug.cgi?id=724382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm open to negotiation for this, but basically...gdm is at
present second only to the kernel in the sheer amount of spew
it emits - when the version is "unstable". But it always will
be for Continuous.
Nowadays of course, I think Continuous helps act as a testing system
for GDM that obviates a lot of the need for lots of debugging info for
gdm during "unstable" cycles.
I suspect that we will over time add other informational messages at
strategic points by default; this patch is not the end of the story.
It's a new beginning.
https://bugzilla.gnome.org/show_bug.cgi?id=715037
|
|
|
|
|
|
|
|
|
| |
This patch add an option (xdmcp/ShowLocalGreeter) to disable the local X
console and turn GDM into a simple XDMCP server
Thanks to Patrick Monnerat and Josselin Mouette for the patch
https://bugzilla.gnome.org/show_bug.cgi?id=567522
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
<Black_Prince> halfline: what's the point of authdir in gdm? (/var/gdm)
?
<Black_Prince> it doesn't appear to be used anywere
<halfline> no point
<Black_Prince> there are some references in daemon/main.c, but nothing
ever gets stored in there
<Black_Prince> instead, xauthdir is used
https://bugzilla.gnome.org/show_bug.cgi?id=706974
|
|
|
|
|
|
|
|
|
|
| |
/var/run/gdm was ending up 0770 in some cases, which
is causing problems.
This commit changes everything to use 0711 across the
board.
https://bugzilla.gnome.org/show_bug.cgi?id=693679
|
|
|
|
|
|
|
|
|
|
|
| |
The level of copy/paste going on here before is rather astonishing.
For example, in some cases, I dropped spurious handling of SIGHUP,
when the code didn't have any settings to reread.
Anyways, the code is now clearer, and we get to drop all the bits of
gdm-signal-handler.[ch] for the integrated GLib handling.
https://bugzilla.gnome.org/show_bug.cgi?id=676181
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modern operating systems have "crash catching" functionality; for
example, systemd comes with "systemd-coredump" which collects cores
automatically.
Attempting to handle these kinds of fatal signals internally is now
much worse, because the original source of the problem will be masked.
systemd won't collect a core file that would include a backtrace, for
example.
Also, with these removed, we can move forward porting to
g_unix_signal_add().
https://bugzilla.gnome.org/show_bug.cgi?id=676181
|
|
|
|
|
|
| |
Both are deprecated and no longer necessary.
https://bugzilla.gnome.org/show_bug.cgi?id=689569
|
|
|
|
| |
This reverts commit 274a430f1fb9abbb2021c1dcae68a140b70d4e77.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently decide whether or not to skip autologin by a first_login
state variable in the static display object.
These days we can have multiple static display objects, so storing the
state variable doesn't make much sense. We could make the variable
static, but instead this commit switches to using a marker file in
/var/run/gdm.
https://bugzilla.gnome.org/show_bug.cgi?id=682467
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=686108
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The daemon startup had lots of swapping around of effective uid, and
aborted if the log/auth directories didn't have the expected permissions.
Honestly this makes no sense - we're uid 0, so let's just ensure
they're directories and call chown() ourself. I have no idea what the
"paranoia" here is about - if someone had managed to e.g. make a
symbolic link in /var to somewhere unexpected, there are plenty of
other ways they could attack the system.
Rather than aborting, let's just call mkdir()/chown()/chmod() and
check the return values.
https://bugzilla.gnome.org/show_bug.cgi?id=684315
|
|
|
|
| |
Fix bug 683383.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GdmManager object controls the GdmLocalDisplayFactory and
GdmXdmcpDisplayFactory singleton objects, which manage displays on local
VTs and displays on remote machines respectively.
Another role of the GdmManager object is to aggregate and export the
displays currently being managed by those display factories over the
system bus.
This commit moves GdmManager over to using GDBus and the
GDBusObjectManager interface for display enumeration.
https://bugzilla.gnome.org/show_bug.cgi?id=622888
|
|
|
|
|
| |
g_atexit is deprecated. For now replace the g_atexit call with
a normal atexit call.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tiny (or not so tiny) bugs in components below GDM in the stack
can lead to critical warnings.
In development releases, GDM by default will crash when encountering
a critical warning.
Losing the login screen is a big deal. We shouldn't automatically subject
our users to "can't log in" in order to highlight bugs in development
releases.
This commit removes fatal criticals by default.
|
|
|
|
| |
The gdm.schemas file is not configurable. It has nothing to do in /etc.
|
|
|
|
|
|
| |
if getpwnam(username) returns NULL, errno needs to be
checked for EINTR. This indicates that a signal was received while waiting for
the blocking call to return, and getpwnam() should be retried.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=594857
|
| |
|
|
|
|
| |
debug/Enable key in the custom.conf file. See bug #596831.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
* daemon/main.c
(bus_proxy_destroyed_cb),
(main)
* gui/simple-chooser/gdm-host-chooser-widget.c,
(xdmcp_discover)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-08-15 William Jon McCann <jmccann@redhat.com>
* common/gdm-signal-handler.c (signal_io_watch),
(gdm_signal_handler_set_fatal_func):
* common/gdm-signal-handler.h:
* daemon/factory-slave-main.c (main):
* daemon/gdm-session-direct.c (stop_worker):
* daemon/gdm-session-worker-job.c (session_worker_job_child_watch):
* daemon/main.c (main):
* daemon/product-slave-main.c (main):
* daemon/session-worker-main.c (main):
* daemon/simple-slave-main.c (main):
* daemon/xdmcp-chooser-slave-main.c (main):
Use a callback for the fatal handler instead of supplying
the main_loop.
svn path=/trunk/; revision=6382
|
|
|
|
|
|
|
|
|
|
|
| |
2008-05-01 William Jon McCann <jmccann@redhat.com>
* daemon/main.c (bus_reconnect):
Might be good to actually start the manager after
reconnecting to the bus.
svn path=/trunk/; revision=6199
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-05-01 William Jon McCann <jmccann@redhat.com>
* NEWS:
* configure.ac:
prepare for release.
* daemon/main.c (bus_reconnect), (bus_proxy_destroyed_cb), (main):
Try to fix a crash at shutdown.
* gui/simple-greeter/gdm-greeter-login-window.c
(do_system_restart), (do_system_stop):
* gui/simple-greeter/test-greeter-login-window.c:
Fix some warnings.
svn path=/trunk/; revision=6197
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-03-17 William Jon McCann <jmccann@redhat.com>
* common/gdm-signal-handler.c: (gdm_signal_handler_finalize):
* daemon/gdm-display.c: (gdm_display_real_create_authority),
(gdm_display_real_add_user_authorization),
(gdm_display_constructor):
* daemon/gdm-slave.c: (gdm_slave_finalize):
* daemon/main.c: (main):
Fix a few more mem and fd leaks.
svn path=/trunk/; revision=6037
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-03-17 William Jon McCann <jmccann@redhat.com>
* common/gdm-common.c: (gdm_wait_on_pid), (gdm_signal_pid),
(_read_bytes), (gdm_generate_random_bytes):
* common/gdm-common.h:
* common/gdm-settings-desktop-backend.c: (parse_key_string),
(gdm_settings_desktop_backend_get_value),
(gdm_settings_desktop_backend_finalize):
* common/gdm-settings-utils.c: (gdm_settings_parse_schemas):
* daemon/gdm-server.c: (server_died), (gdm_server_stop):
* daemon/gdm-session-worker-job.c: (session_worker_job_died),
(gdm_session_worker_job_stop):
* daemon/gdm-slave-proxy.c: (child_watch), (kill_slave),
(gdm_slave_proxy_stop), (gdm_slave_proxy_dispose),
(gdm_slave_proxy_finalize):
* daemon/gdm-welcome-session.c: (stop_dbus_daemon),
(welcome_session_died), (gdm_welcome_session_stop):
* daemon/main.c: (main):
* gui/simple-greeter/gdm-remote-login-window.c: (xserver_died):
* gui/simple-greeter/gdm-session-client.c: (client_died),
(gdm_session_client_stop):
Move wait_on_child to common. Always check return value of
gdm_signal_pid. Fix a number of small leaks. Make sure
to signal the slaves when exiting.
svn path=/trunk/; revision=6036
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-03-10 William Jon McCann <jmccann@redhat.com>
* common/gdm-signal-handler.c: (signal_io_watch),
(crashlogger_get_backtrace), (gdm_signal_handler_backtrace),
(signal_handler), (gdm_signal_handler_add_fatal):
* common/gdm-signal-handler.h:
* daemon/main.c: (signal_cb), (main):
* gui/simple-greeter/greeter-main.c: (signal_cb), (main):
Don't glog in the signal handlers. Add a default
SIGTRAP handler so we get backtraces in unstable releases.
svn path=/trunk/; revision=5991
|
|
|
|
|
|
|
|
|
|
| |
2008-02-27 Ray Strode <rstrode@redhat.com>
* daemon/main.c (main):
ignore unknown options, so removed options don't cause it to
abort
svn path=/trunk/; revision=5889
|
|
|
|
|
|
|
|
|
|
| |
2008-02-26 William Jon McCann <jmccann@redhat.com>
* daemon/main.c: (main):
Don't daemonize and remove some unused options.
svn path=/trunk/; revision=5883
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2008-02-20 William Jon McCann <jmccann@redhat.com>
* common/gdm-settings-keys.h:
* common/test-settings-client.c: (test_settings_client):
* daemon/gdm-manager.c: (gdm_manager_class_init):
* daemon/main.c: (main):
Set XDMCP enabled/disabled from configuration settings.
svn path=/trunk/; revision=5827
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-11-19 William Jon McCann <mccann@jhu.edu>
* common/gdm-common-unknown-origin.h:
* configure.ac:
* daemon/Makefile.am:
* daemon/gdm-greeter-session.c:
* daemon/gdm-server.c: (gdm_server_class_init):
* daemon/gdm-session-record.c: (record_set_username),
(gdm_session_record_login), (gdm_session_record_logout):
* daemon/gdm-session-worker-job.c:
(gdm_session_worker_job_class_init):
* daemon/gdm-slave-proxy.c: (spawn_slave):
* daemon/main.c:
* gui/settings-daemon/plugins/xsettings/gdm-xsettings-manager.c:
* gui/simple-chooser/gdm-host-chooser-widget.c: (do_ping):
Fix build on FreeBSD.
Patch from: Joe Marcus Clarke <marcus@freebsd.org>
svn path=/trunk/; revision=5515
|
|
|
|
|
|
|
|
|
|
|
| |
2007-10-31 William Jon McCann <mccann@jhu.edu>
* configure.ac:
Add Xau and Xext to XLIB_LIBS when x11.pc isn't
found. Fixes #492022 more
svn path=/trunk/; revision=5480
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-10-26 William Jon McCann <mccann@jhu.edu>
* common/gdm-common.c: (gdm_set_fatal_warnings_if_unstable):
* common/gdm-common.h:
* daemon/factory-slave-main.c: (main):
* daemon/main.c: (main):
* daemon/product-slave-main.c: (main):
* daemon/simple-slave-main.c: (main):
* gui/simple-greeter/greeter-main.c: (main):
Use assertions for criticals everywhere for unstable
builds.
svn path=/trunk/; revision=5427
|