summaryrefslogtreecommitdiff
path: root/daemon
Commit message (Collapse)AuthorAgeFilesLines
* session-worker: kill user sessions when stopping gdm serviceXiaoguang Wang2019-06-272-9/+63
| | | | | | | | | | | | | | | | | At the moment the session worker exits as soon as it gets SIGTERM. That means it may fail to stop the user session (which only happens in the orderly shutdown path). This commit sets up a SIGTERM handler that integrates with and quits the main loop after the session is started. It still retains the _exit-on-SIGTERM behavior before the session is started, to ensure a stuck pam module doesn't prevent the process from dying. Some small changes to commit by Ray Strode. Closes #400
* session-worker: expose worker state enum to type systemRay Strode2019-06-275-12/+92
| | | | | | | | We're going to need to access the worker state as a property on the worker object. This commit hooks it up to glib-mkenums so the requisite goo can get generated
* GdmDisplay: Remove an unused GErrorIain Lane2019-05-291-1/+0
|
* Allow sessions to register with GDMIain Lane2019-05-296-77/+199
| | | | | | | | | | | | | | | | | | | | | | Recording when sessions start, for Wayland → Xorg fallback or transitioning to the user session, is currently done with timeouts. This isn't ideal, because on some very slow machines the timeout can be hit before the session has had a chance to fail: if gnome-session takes more than 3 seconds to fail then the session will be considered to have exited rather than failed, and so we don't do Xorg fallback. We can do this more reliably if we allow sessions to optionally register themselves with GDM. Then we will know when they've started, so can shut down the greeter or fall back to Xorg as appropriate. The mechanism is that they specify X-GDM-SessionRegisters=true in their file, and then call RegsterSession on the DisplayManager interface on the bus (added in the previous commit) to say that they've started up. If X-GDM-SessionRegisters is missing or false, GDM will call the same method for them after 10 seconds. Closes: #483
* GdmManager, GdmDisplay: Add RegisterSession methodIain Lane2019-05-293-0/+60
| | | | | Window managers can use this to register with GDM when they've finished starting up and started displaying.
* GdmLocalDisplayFactory: Store VT number, not tty identifierIain Lane2019-05-293-26/+28
| | | | This makes the code a fair bit simpler.
* manager: don't return value from listify_display_idsRay Strode2019-02-211-4/+1
| | | | | | | | The manager code is returning FALSE from its listify_display_ids foreach function, which is useless since commit 47d01abe. This commit makes it return void instead.
* local-display-factory: don't return value from foreach funcsRay Strode2019-02-211-4/+2
| | | | | | | | The local display factor code is returning FALSE from its display store foreach functions, which is useless since commit 47d01abe. This commit makes it return void instead.
* xdmcp-display-factory: don't return value from foreach funcsRay Strode2019-02-211-6/+2
| | | | | | | | The xdmcp code is returning TRUE from its display store foreach functions, which is useless since commit 47d01abe and wrong before that. This commit makes it return void instead.
* display-store: make foreach ignore callback return valuexiaoguang wang2019-02-211-3/+13
| | | | | | | | | | | | | gdm_display_store_foreach is designed to iterate through all displays in the display store. Under the hood, it currently uses gdm_display_store_find, though, so will prematurely stop it's loop if a callback returns TRUE. Callers are getting this wrong. Some return TRUE with the expectation it goes on, and some fail to return a value at all. This commit changes gdm_display_store_foreach to use g_hash_table_foreach instead, so the callback return values no longer matter.
* GdmManager: Don't perform timed login if session gets startedIain Lane2019-02-071-0/+8
| | | | | | | | | | | | | | | | | | | | | | At the moment it's possible for the login screen to initiate a timed login operation shortly after a user successfully starts their session. GDM won't complete the timed login operation, since a session is already running, but will erroneously overwrite the username associated with the session, misattributing the users session to the timed login user. Later, attempts to log in as the timed user will instead unlock the session for the other user, since that session is now associated with the timed login user. This commit refuses timed login requests on sessions that are already running, so the username doesn't get corrupted. CVE-2019-3825 Closes https://gitlab.gnome.org/GNOME/gdm/issues/460
* session: Don't allow greeter operations on an running sessionIain Lane2019-02-071-0/+75
| | | | | | | If a client has a reference to a session that starts running, refuse to allow further operations on the session. CVE-2019-3825
* manager,session: Add some debugging around starting reauthenticationIain Lane2019-02-062-10/+61
| | | | | | | | There's a bug right now dealing with timed login and reauthentication, but it's not clear what's going on by looking at the logs. This commit sprinkles some more logging throughout the code, to make the bug easier to track.
* manager: don't kill timed login session immediately after it startsRay Strode2019-02-061-1/+2
| | | | | | | | | At the moment GDM is misidentifying timed login sessions as if they are automatic login sessions. That leads to their displays getting killed sometimes shortly after log in. This commit corrects the check, so that timed login sessions aren't treated as autologin sessions.
* Use G_PARAM_STATIC_STRIGS on propertiesNiels De Graef2019-01-0712-75/+75
| | | | This prevents strings from being unnecessarily copied.
* session: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-359/+294
|
* display-access-file: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-58/+38
|
* session-worker-job: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-77/+45
|
* server: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-115/+85
|
* session-solaris-wayland: Use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-64/+39
|
* session-linux-auditor: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-252-34/+9
|
* session-auditor: use G_DECLARE_DERIVABLE_TYPENiels De Graef2018-12-252-39/+40
|
* xdmcp-display: use G_DECLARE_DERIVABLE_TYPENiels De Graef2018-12-232-39/+33
|
* local-display: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-232-30/+6
|
* legacy-display: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-232-41/+17
|
* display: use G_DECLARE_DERIVABLE_TYPENiels De Graef2018-12-232-230/+355
|
* local-display-factory: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-232-76/+54
|
* xdmcp-display-factory: use G_DECLARE_FINAL_TYPENiels De Graef2018-12-232-217/+195
|
* display-factory: use G_DECLARE_DERIVABLE_TYPENiels De Graef2018-12-232-39/+35
|
* manager: do initial-setup post work in manager codeRay Strode2018-10-062-132/+132
| | | | | | | | | | | | Right now we do the initial-setup related post work when stopping the greeter, but the problem is we delay stopping the greeter now until after the user session is started. That post-work needs to be done before the user session is started. This commit moves the code to a more logical place.
* manager: correct display confusionRay Strode2018-10-011-2/+2
| | | | | | | | | commit c5c5bf1f reworked autologin and broke it. This commit addresses the breakage by accessing the proper display variable. Closes https://gitlab.gnome.org/GNOME/gdm/issues/426
* local-display-factory: handle reviving displays that are waiting to dieRay Strode2018-09-251-1/+4
| | | | | | | | We may end up re-using a display in waiting-to-finish state before it gets finished in this case reset its state to managed to avoid it getting finished while it is being used. Closes https://gitlab.gnome.org/GNOME/gdm/merge_requests/45
* local-display-factory: Remove same VT so don't switch checkRay Strode2018-09-251-26/+13
| | | | | | | | | We avoid changing to the login screen vt if we're already on it, but the call is racy since we react to vt changes concurrently with logind (who we query for the active vt). This check drops the active vt check since it's pointless and getting in the way.
* local-display-factory: Remove initial VT is in use checkHans de Goede2018-09-251-13/+0
| | | | | | | | | | | | | | | | | | | | | | The initial VT is in use check in on_vt_changed() is racy, when switching to VT1 from an active session, on_vt_changed() may run before logind has processed the VT change and then sd_seat_get_active() will return the active session which we are switching away from. This results in the greeter not being started on VT1. On my system gdm reliably wins the race resulting in not getting a greeter when manually switching from an active session to VT1. gdm already starts the greeter unconditionally from gdm_local_display_factory_sync_seats() on both startup and when an user session exits. gdm also starts it unconditionally when selecting "Switch user" from an user session. Now autologin sessions avoid the initial VT as well. So we now can assume that the initial VT is free for the login screen's use. And create_display already checks for and re-uses an existing greeter, so we can safely remove the racy check.
* manager: don't run autologin display on tty1Ray Strode2018-09-251-3/+1
| | | | | | | | | | tty1 is really meant for the login screen. If a user autologins on it and we need a login screen later, then the login screen has to go in some auxiliary VT which isn't very nice. This commit changes autologin to not use the initial vt.
* manager: rework how autologin is figured outRay Strode2018-09-251-11/+35
| | | | | | | | | | | | At the moment we decide whether or not to perform autologin, by looking at if the display is the initial VT display and if autologin hasn't been started before. That isn't going to work in the future when autologin is started on a non-initial vt. This commit changes GDM to instead check if the seat is seat0, and if autologin hasn't run before, before deciding to do autologin.
* local-display-factory: don't autoreap initial-setupRay Strode2018-09-251-0/+8
| | | | | | | | We automatically kill the login screen when switching VTs away from it, but we should never kill the initial-setup screen in that situation. This commit adds a check to prevent that from happening.
* daemon: Move the waiting the session to have taken over the fb to ↵Hans de Goede2018-09-123-36/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gdm-local-display-factory Commit 708618746683 ("gdm-wayland-session,gdm-x-session: register after delay") delayed displays changing their status from PREPARED to MANAGED so that their status would not change until the session has had a change to install its own framebuffer and tell the GPU to scanout this new fb. Commit 74ee77717df7 ("local-display-factory: defer killing greeter until new session registers") uses this to avoid a flicker when transitioning from the greeter to the user-session by deferring the stopping of the greeter-session until the new display moves to the MANAGED state. But this only works when transitioning to a new user-session, when moving to an existing user-session (fast user switching) the display already is in MANAGED state and instead of deferring the stopping of the greeter commit 74ee77717df7 causes us to now never stop the greeter-session. This commit fixes this by starting a timeout when switching away from the initial-vt and letting that timeout stop the greeter-session. This commit removes the finish_waiting_displays_on_seat() call when the display's status changes to MANAGED, so that we still only have one code path stopping the greeter and not two. This means we also no longer need to delay registering the display. So this commit removes the code adding the delay (reverts commit 74ee77717df7). Note this commit uses a delay of 10 seconds, rather then 2 seconds. The transition to a new user-session takes about 8 seconds on my budget Apollo Lake based laptop (with SSD). Note this all really is a workaround, the proper solution for this would be able to tell the kernel to keep the greeter framebuffer around until a new framebuffer is installed. There is a patch to add a new unref_fb ioctl for this: https://www.spinics.net/lists/dri-devel/msg140912.html . We need to get this patch upstream and teach mutter to use it.
* local-display-factory: fix build with --disable-user-display-serverRay Strode2018-09-011-1/+1
| | | | | | | | | | | | | commit cf8d918f added a call to `lookup_by_session` which was previously only defined when built GDM was built with `--enable-user-disable-server`. That causes the build to fail with `--disable-user-display-server`. This commit fixes the build by moving `lookup_by_session` out of conditionalized code. Closes https://gitlab.gnome.org/GNOME/gdm/issues/416
* manager: fix build with --without-plymouthRay Strode2018-09-011-2/+2
| | | | | | | | | | | commit 80b46e2 accidentally put the `doing_initial_setup` boolean declaration inside a plymouth-enabled code path. That broke the build for non-plymouth users. This commit moves the declaration and the subsequent initialization to unconditionalized code.
* manager: don't kill initial-setup before starting user session on waylandRay Strode2018-08-311-5/+21
| | | | | | | | | | Right now we kill initial-setup before starting the session for the user initial-setup created. This is the right thing to do for Xorg, since Xorg can't be killed in the background, but it adds unncessary flicker for wayland. This commit checks if it's wayland and avoids killing it right away in that case.
* launch-environment: use wayland for initial-setupRay Strode2018-08-314-12/+11
| | | | | | | | | | | While we've been using wayland by default for the login screen for a long time, and for the user session for somewhat less time, we never switched initial setup over. It's still using X11 for no good reason. This commit changes initial-setup to use wayland by default like everything else.
* local-display-factory: defer killing greeter until new session registersRay Strode2018-08-312-6/+38
| | | | | | | | | | | | At the moment we kill the greeter the second the VT change to the new session happens. That can cause flicker if the new session doesn't take over the display quickly enough. This commit defers killing the greeter until the new display registers. Closes https://gitlab.gnome.org/GNOME/gdm/issues/413
* gdm-wayland-session,gdm-x-session: register after delayRay Strode2018-08-312-15/+33
| | | | | | | | | | | | | | | | Right now gdm-x-session registers with GDM as soon as the X server is started, and gdm-wayland-session registers as soon as the session is started. Ideally registration wouldn't happen until the session says things started successfully. This commit inches us toward that ideal but adding a little timeout before proceeding with registration. A future commit will add a new xsession file key to allow us to know whether or not the session manager of the session supports doing registration.
* manager: start initial setup right awayRay Strode2018-08-311-66/+1
| | | | | | | | | | | | | | We no longer restart the greeter as soon as it dies, since we start the greeter on demand. This means, we no longer need to defer starting initial setup until after the greeter respawns. Furthermore, it doesn't work anymore since it relied on the respawn to trigger. This commit removes that code and scaffolding and just starts initial setup directly. https://gitlab.gnome.org/GNOME/gdm/issues/415
* manager: don't set ran_once after running initial-setupRay Strode2018-08-311-1/+3
| | | | | | | | | | | GdmManager tracks whether or not the user session has ran once, so it won't autologin a user again after logout. Unfortunately the initial-setup session was counting toward the ran_once count preventing initial-setup from logging the user in afterward. This commit prevents ran_once from getting set in that case.
* session-worker: fix current vt detection short-circuit logicRay Strode2018-08-311-1/+1
| | | | | | | | | | commit 8169cd4 attempts to avoid changing VTs if the active VT is the same as the VT getting jumped to. It fails to work, however, because accidentally treats a 0 return code to the VT_GETSTATE ioctl as failure. this commit fixes that.
* session-worker: clear VT before jumping to itRay Strode2018-08-311-0/+7
| | | | | | | | | If we're going to jump to a new VT we should make sure it's free of residual console text. That way if there's flicker the user will be less likely to notice it. This commit sends a clear screen escape sequence to the tty before jumping to it.
* manager: better logind handlingRay Strode2018-08-311-3/+3
| | | | | | | | commit 9ee68d5c8 highlights we've incorrectly used ENOENT instead of ENXIO when checking for non-existing sessions/seats with logind. This commit mops up all the other cases.
* manager: plug leakRay Strode2018-08-311-1/+1
| | | | | We're quering the session-type of a display and not freeing the result.
View Lorry Controller Status