summaryrefslogtreecommitdiff
path: root/daemon
Commit message (Collapse)AuthorAgeFilesLines
* gdm-manager: Plug a memory leakAlessandro Bono2023-04-281-1/+1
| | | | client_session_is is not freed. While at it, use g_autofree.
* gdm-server: Plug a memory leakAlessandro Bono2023-04-281-9/+3
| | | | | identifier was not freed. While at it use g_autofree and simplify how the identifier is created.
* gdm-local-display: Remove dead codeAlessandro Bono2023-04-281-4/+0
|
* gdm-local-display-factory: Remove unused variableAlessandro Bono2023-04-281-1/+0
|
* gdm-local-display-factory: Move variables to inner scopeAlessandro Bono2023-04-281-3/+4
|
* gdm-legacy-display: Use g_auto*Alessandro Bono2023-04-281-13/+6
|
* gdm-legacy-display: Plug a memory leakAlessandro Bono2023-04-281-7/+3
| | | | | display_name and seat_id were leaked. While at it, use g_autoptr() for launch_environment.
* gdm-launch-environment: Use g_auto*Alessandro Bono2023-04-281-36/+21
|
* gdm-launch-environment: Remove redudant checkAlessandro Bono2023-04-281-2/+0
| | | | | g_return_if_fail (GDM_IS_LAUNCH_ENVIRONMENT (object)) already checks it it is NULL.
* gdm-display: Use g_auto*Alessandro Bono2023-04-281-64/+25
|
* gdm-display: Plug a memory leakAlessandro Bono2023-04-281-2/+1
| | | | error was not freed in the second if branch. While at it use g_autoptr.
* gdm-display-access-file: Use g_auto*Alessandro Bono2023-04-281-42/+20
|
* gdm-dbus-util: Use g_auto*Alessandro Bono2023-04-281-27/+12
|
* session-worker: fix finalize criticals when user_settings is NULLMichael Catanzaro2023-03-271-1/+1
| | | | | | | This is a really classic case where we try to call g_object_unref() on an object that is expected to be NULL. Don't do that. Fixes #730
* added sighup handler for session-worker-maingangmo seong2023-03-031-0/+8
|
* session-worker-job: minor cleanupsIgnacio Casal Quinteiro2023-01-201-43/+25
|
* gdm-session: Add missing guards in public functionsAlessandro Bono2022-10-291-7/+40
|
* gdm-session-worker-job: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+6
|
* gdm-session-settings: Add missing guards in public functionsAlessandro Bono2022-10-291-1/+3
|
* gdm-session-auditor: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+12
|
* gdm-server: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+4
|
* gdm-manager: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+4
|
* gdm-launch-environment: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+8
|
* gdm-display: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+13
|
* gdm-display-store: Add missing guards in public functionsAlessandro Bono2022-10-291-8/+8
|
* gdm-display-factory: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+2
|
* gdm-display-access-file: Add missing guards in public functionsAlessandro Bono2022-10-291-6/+10
|
* gdm-dbus-util: Add missing guards in public functionsAlessandro Bono2022-10-291-0/+6
|
* gdm-local-display-factory: Move early return on topAlessandro Bono2022-10-281-27/+29
| | | | | | There is no need to perform all the checks if the display is already created. While at it, add a debug message to make easier to understand the message when a display already exists.
* gdm-local-display-factory: Improve debug messageAlessandro Bono2022-10-281-1/+1
|
* gdm-local-display-factory: Move display existence check to its own functionAlessandro Bono2022-10-281-8/+22
|
* gdm-local-display-factory: Remove redundant checkAlessandro Bono2022-10-281-4/+6
| | | | | | | | | | There is no case where seat_supports_graphics is TRUE while session_types is NULL. Thus, after the following check: ``` if (!seat_supports_graphics) return; ``` we can assume that session_types won't be NULL.
* gdm-local-display-factory: Move variables to inner scopesAlessandro Bono2022-10-281-2/+4
|
* gdm-local-display-factory: Remove unused variablesAlessandro Bono2022-10-281-5/+0
|
* gdm-local-display-factory: Set is_seat0 right awayAlessandro Bono2022-10-281-5/+2
|
* gdm-session-worker: Assert that service cannot be NULLAlessandro Bono2022-10-271-0/+1
| | | | | pam_start() requires the first, third and fourth arguments to not be NULL. Assert that the first one is not NULL.
* gdm-display: Simplify codeAlessandro Bono2022-10-271-5/+1
| | | | | | | | | Just pass the error we received from the caller. While this doesn't change much, it avoids a scan-build warning: ../daemon/gdm-display.c:213:73: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') [core.NullDereference] g_critical ("could not create display access file: %s", error->message); ^~~~~~~~~~~~~~
* gdm-display-access-file: Check _get_uid_and_gid_for_user() return valueAlessandro Bono2022-10-271-1/+9
| | | | | | While it is unlikely that the gdm user is not installed on the system, check the returning value of _get_uid_and_gid_for_user(), so that we are not going to read a garbage value from the gid variable.
* gdm-display-access-file: Fix capitalizationAlessandro Bono2022-10-271-1/+1
|
* gdm-session-worker: Remove dead codeAlessandro Bono2022-10-271-1/+0
| | | | Value stored to 'fd' is never read.
* gdm-session-worker: Remove dead codeAlessandro Bono2022-10-271-2/+0
| | | | Values stored to 'ret' and 'aux_buffer_size' are never read.
* gdm-display: Remove dead codeAlessandro Bono2022-10-271-1/+0
| | | | Value stored to 'ret' is never read
* gdm-session-worker-job: Remove dead codeAlessandro Bono2022-10-271-2/+0
| | | | Value stored to 'ret' is never read.
* manager: Fix btmp record accountingRay Strode2022-10-272-6/+19
| | | | | | | | | | | | | Before a user logs in they don't have a display. btmp records currently need a display though, and they get written when the user can't log in. Furthermore, the display from X11 point of view is somewhat archaic. We use wayland by default now. In lieu of a display, this commit gives the btmp record the seat id instead.
* gdm-local-display-factory: Remove unused variableAlessandro Bono2022-10-271-1/+0
| | | | Unused since eba8deb7f92f473a40a8e277203d86aeab879bd1.
* gdm-session-record: Don't use g_get_current_timeAlessandro Bono2022-10-271-4/+4
| | | | It is deprecated since GTimeVal is not year-2038 safe.
* gdm-xdmcp-display-factory: Use g_clear_handle_idAlessandro Bono2022-10-271-7/+2
|
* gdm-session-worker: Use g_clear_handle_idAlessandro Bono2022-10-271-12/+1
|
* gdm-session-worker-job: Use g_clear_handle_idAlessandro Bono2022-10-271-4/+1
|
* gdm-local-dispay-factory: Use g_clear_handle_idAlessandro Bono2022-10-271-8/+2
|
View Lorry Controller Status