summaryrefslogtreecommitdiff
path: root/gui/gdmchooser.c
Commit message (Collapse)AuthorAgeFilesLines
* Cleaner fix for same problem fixed in last commit.Brian Cameron2006-12-051-14/+2
| | | | | | | 2006-12-05 Brian Cameron <brian.cameron@sun.com> * vicious-extensions/ve-miscui.c, gui/gdmchooser.c: Cleaner fix for same problem fixed in last commit.
* Fix so that if the "%" key is entered in the input field in gdmchooser,Brian Cameron2006-12-051-2/+14
| | | | | | | | | | | 2006-12-04 Brian Cameron <brian.cameron@sun.com> * vicious-extensions/ve-miscui.c, gui/gdmchooser.c: Fix so that if the "%" key is entered in the input field in gdmchooser, the secondary message in the error dialog displays properly. Also fix ve-miscui.c so that if "%" exists in the secondary message, to not display it. Message must have "%%" to display the "%" character.
* Fix gdm_common_setup_blinking so it doesn't try to callBrian Cameron2006-07-311-1/+1
| | | | | | | | | | | | | | 2006-07-31 Brian Cameron <brian.cameron@sun.com> * ui/gdmcommon.c: Fix gdm_common_setup_blinking so it doesn't try to call g_signal_add_emission_hook if sid is 0. This fixes a crash in gdmchooser because we were trying to set the emission hook for a type that was not used or initialized in the gdmchooser GUI. This fixes bug #349221. * gui/gdmcommon.c: Set hosts_opt to NULL, otherwise processing of hosts from the command line would not get done if the compiler put a non-NULL value into its initial value, as it does on Solaris.
* Fix setting of GdmHosts so it should use the hosts from the config fileBrian Cameron2006-04-171-25/+30
| | | | | | | | | | | | 2006-04-17 Brian Cameron <brian.cameron@sun.com> * gui/gdmchooser.c: Fix setting of GdmHosts so it should use the hosts from the config file when when BROADCAST/MULTICAST is set to false. Partial fix for #338274. Thanks to Tiago Vignatti <tv02@c3sl.ufpr.br> for noticing this. * configure.ac, po/LINGUAS: Updated to reflect latest po/LINGUAS patch. Fixes bug #33769. Patch provided by Przemyslaw Grzegorczyk <pgrzegorczyk@gmail.com>.
* Updated NEWS. Fix references to the BROADCAST key so it is correctlyBrian Cameron2006-04-131-2/+2
| | | | | | | | 2006-04-13 Brian Cameron <brian.cameron@sun.com> * NEWS: Updated NEWS. * gui/gdmchooser.c: Fix references to the BROADCAST key so it is correctly listed as a bool, not a string.
* Now support --with-sysconfsubdir so that GDM can be configured to have theBrian Cameron2006-03-281-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | 2006-03-27 Brian Cameron <brian.cameron@sun.com> * acconfig.h, configure.ac, config/Makefile.am, config/PostLogin, config/gdm.conf.in, daemon/Makefile.am, daemon/gdm.[ch], daemon/gdmconfig.c, gui/Makefile.am, gui/greeter/Makeifle.am, gui/modules/Makefile.am, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c, utils/Makefile.am: Now support --with-sysconfsubdir so that GDM can be configured to have the config files in a directory that isn't hardcoded to have "/gdm" at the end. Fixes bug #335957. Patch provided by Julio M Merino Vidal <jmmv@NetBSD.org> with minor changes by me to fix some usage of EXPANDED_GDMCONFDIR that caused breakage on Solaris. * gui/gdmXnestchooser, gui/gdmchooser.c, gui/gdmcomm.[ch], gui/gdmdynamic.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/greeter/greeter.c: Now use gdmcomm_comm_bulk_start and gdmcomm_comm_bulk_stop to wrap areas of the code where we want to keep the sockets connection open for performance. This makes gdmsetup start faster and better ensures that sockets are not left open. Now gdmcomm_call_gdm will always close the socket unless inside such a block, ensuring that if distros add patches to read new config values at random points in the code, the socket won't be left open. * daemon/gdm.c: Fix gdm_debug message.
* A known issue with gdmdynamic is that when a display connects to theBrian Cameron2006-02-091-25/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A known issue with gdmdynamic is that when a display connects to the server it generates the gdmdynamic "ADD" and "RELEASE" commands. On startup, hundreds of displays could send these commands at once and cause the server too be flooded with sockets requests. Hammering the socket like this caused me to find and fix a number of problems that improve socket reliability for general GDM use. I also enhanced gdmdynamic so it is more sensitive to the socket being busy and no longer overloads it, instead sleeping and retrying if necessary. This allows gdmdynamic to work if there are hundreds of displays instead of just a dozen or so. * daemon/gdm.[ch]: Added new "SERVER_BUSY" sockets command so that gdmdynamic can sleep before starting new slaves if the daemon is already busy. * daemon/gdm-net.[ch]: Bump up MAX_CONNECTIONS from 10 to 15. I notice that this improves performance significantly when hammering the daemon with connections. Added better comments for this logic and now debug logs when a subconnection is thrown away. New gdm_connection_is_server_busy function * daemon/display.c: Correct DYNAMIC_REMOVE so it works and fixes bug #326796. Before it wasn't really removing the displays. * gui/gdmdynamic.c: Quite a bit of work to make gdmdynamic avoid flooding the server with sockets requests. Now it sets sockets retries to 1 and manages sleeping and retries itself. * gui/gdmconfig.c: Added gdm_config_set_comm_retries so that slaves can specify how many retries they want the comm logic to use. * gui/gdmcomm.c: Now do_command returns NULL when it gets back "", which happens when a subconnection was dropped by the daemon. This lets the slave try the connection again. Now error messages are always logged, not just when debug is turned on. Added gdmcomm_did_connection_fail and gdmcomm_set_allow_sleep so gdmdynamic can control the behavior of how the connection works. * gui/gdmcommon.c, gui/gdmchooser.c, gui/gdmlogin.c, gui/greeter/greeter.c: Fix gdm_common_fail so it doesn't generate compile errors when building with GCC. Fixes bug #330480. * docs/C/gdm.xml: Cleaned up section that explains sockets commands so that they are in alphabetical order, added info about SERVER_BUSY and new gdmdynamic -s and -t options. * config/gdm.conf: Better description of how debug works, perhaps I just didn't like the word "spew". ---------------------------------------------------------------------
* This patch resolves some performance issues that I noticed when testingBrian Cameron2006-02-071-100/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2006-02-07 Brian Cameron <brian.cameron@sun.com> This patch resolves some performance issues that I noticed when testing GDM with the gdmdynamic command. I notice that waiting for the sockets to timeout made gdmdynamic slower so now all the clients load all the configuration data in one quick pass and close the socket. Since the gdm_config_get functions cache the data, the slaves will not go over the socket to get the data again unless asked to reread. Bump the maximum messages over the socket from 20 to 80 because gdmlogin pulls about 65 configuration parms over and this allows all data to be accessed in one connection (and gives a little room for growth). Improved the way GDM slaves deal with syslog so all slaves use the same interfaces. Added three missing keys to the daemon configuration handling code. * daemon/gdmconfig.c: Add three keys that were missing for background program support. * gui/gdmcomm.[ch]: Now if there is a failure connecting to the daemon, the slave will sleep 1 second before retry (normally retries 5 times). If all retries fail, it will not try sleeping on subsequent calls to the daemon. This greatly improves performance when the daemon is flooded with slave requests. In normal usage, this will likely not happen, but it is good for GDM to not fail so easily. Added better debug. Added gdm_comm_close function so that slaves can ask to close the socket when done reading config. Now uses common syslog functions. * daemon/gdm.h: Add better comments, rename GDM_SUP_MAX_CONNECTIONS to GDM_SUP_MAX_MESSAGES which is more accurate, and bump the max number to 80. * gui/gdmcommon.h, gui/gdmwm.h, gui/gdmsession.h: Added common syslog functions to gdmcommon.h and moved some functions that were in gdmcommon.h to gdmwm.h and gdmsession.h since the implementations were in those c-files. Renamed functions to make naming consistant. * gui/gdmXnestchooser, gui/gdmchooser.c, gui/gdmcommon.c, gui/gdmconfig.c, gui/gdmdynamic.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsession.c, gui/gdmwm.c, gui/greeter/greeter.c, gui/greeter/greeter_item_ulist.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: Slaves close sockets connection when done reading config. Now slaves use common syslog functions. Naming changes to reflect renaming of functions in gdmcommon.h/gdmwm.h/gdmsession.h. Better debug. * daemon/auth.c, daemon/cookie.c, daemon/display.c, daemon/gdm.c, daemon/gdm-net.c, daemon/misc.c, daemon/slave.c, daemon/xdmcp.c, gui/gdmlanguages.c, gui/greeter/greeter_canvas_item.c, gui/gdmsetup.c, vicious-extensions/ve-config.c: Make spacing around "++" more consistant. Add better debug in some functions
* Add needed glib/gstdio.h include to daemon/fstype.c which fixes a wierdBrian Cameron2006-01-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | 2006-01-18 Brian Cameron <brian.cameron@sun.com> * daemon/auth.c, daemon/choose.c, daemon/cookie.c, daemon/display.c, daemon/errorgui.c, daemon/filecheck.c, daemon/fstype.c, daemon/gdm.c, daemon/gdmconfig.c, daemon/server.c, daemon/slave.c, daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c, daemon/xdmcp.c, gui/gdmchooser.c, gui/gdmlogin.c, gui/gdmsession.c, gui/gdmsetup.c, gui/misc.c, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c, utils/gdm-dmx-reconnect-proxy.c, vicious-extensions/glade-helper.c, vicious-extensions/test-ve-config.c, vicious-extensions/ve-config.c, vicious-extensions/ve-gnome.c, vicious-extensions/ve-misc.c, vicious-extensions/ve-miscui.c, vicious-extensions/ve-nongnome.c, vicious-extensions/ve-signal.c: Add needed glib/gstdio.h include to daemon/fstype.c which fixes a wierd core dumping problem on Ubuntu. Fixes bug #326819. Patch provided by Sebastien Bacher <seb128@debian.org>. Also fixed all the source so that the includes are more consistant with config.h in quotes instead of in "<>" and glib/gtk includes are always listed after system includes.
* Happy holidays. Some bug fixes.Brian Cameron2005-12-251-2/+2
| | | | | | | | | | | | | | | | | | | | | | 2005-12-24 Brian Cameron <brian.cameron@sun.com> Happy holidays. Some bug fixes. * daemon/gdm.h, daemon/gdmconfig.c, daemon/slave.c, gui/gdmlogin.c, gui/greeter/greeter_item_timed.c: Fix so that timed/automatic enable is checked and automatic/timed login is only turned on if they are enabled. Fix so greeters restart if timed login is changed in gdmsetup. Fixes bug #324337. * gui/gdmcommon.c, gui/gdmlogin.c, gui/greeter/greeter.c, gui/greeter/greeter_item.c, gui/greeter/greeter_parser.c: Now gdmlogin and gdmcommon use the same character sequences with Welcome/RemoteWelcome messages. Fixes bug #322711. * docs/C/gdm.xml: Document how character sequences work with text labels and Welcome/RemoteWelcome messages. * gui/gdmcommon.[ch], gui/gdmchooser.c, gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_geometry.c: Rename functions so all common functions have prefix gdm_common.
* Now use g_ stdio function like g_chmod instead of chmod. Fixes bugBrian Cameron2005-12-221-3/+3
| | | | | | | | | | | | | | | | 2005-12-22 Brian Cameron <brian.cameron@sun.com> * daemon/auth.c, daemon/display.c, daemon/errorgui.c, daemon/filecheck.c, daemon/fstype.c, daemon/gdm-net.c, daemon/gdm.[ch], daemon/gdmconfig.c, daemon/misc.c, daemon/server.c, daemon/slave.c, daemon/verify-pam.c, daemon/xdmcp.c, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcommon.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/gdmuser.c, utils/gdmprefetch.c, vicious-extensions/ve-config.c, vicious-extensions/ve-gnome.c, vicious-extensions/ve-misc.[ch], vicious-extensions/ve-nongnome.c: Now use g_ stdio function like g_chmod instead of chmod. Fixes bug #310229.
* After two months, the redesign of GDM's internal configuration is finallyBrian Cameron2005-12-201-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-12-21 Brian Cameron <brian.cameron@sun.com> After two months, the redesign of GDM's internal configuration is finally reaching a close. Now GDM users are instructed to not modify the gdm.conf file directly and instead put any cutomizations in a separate file called gdm.conf-custom (read the comments in both files). gdmsetup now modifies the gdm.conf-custom file. The GDM daemon will now use values in gdm.conf-custom first and the default values in gdm.conf if no value is defined in gdm.conf-custom. Benefits: 1) Now GDM truly supports system-wide and machine-specific config. System wide configuration is when the sysadmin wants to share the main gdm.conf file across multiple systems on a shared file system (possible by building GDM with the --with-configdir option or by running GDM with the --config option). Specific systems can override defaults by modifying the gdm.conf-custom file. 2) Distros can stomp the main gdm.conf file on upgrade knowing that any user changes are stored in a separate file. For best backwards compatibility, distros will need to move the gdm.conf file to gdm.conf-custom if the gdm.conf file exists on the system but the gdm.conf-custom file does not. 3) Making this work required a lot of cleanup in the way GDM manages its configuration files. For example, now config options are managed via access functions, and do not depend on non-static globals being shared across files. The GET_CONFIG and UPDATE_CONFIG commands work better and do not require special tweaking when adding new config options. Vicious-extensions is now only included in a few files that need to know how to access the config files directly. This makes GDM support a popular feature in CDE which works similarly. (config files in /etc/dt/config take precidence over the ones in /usr/dt/config). * daemon/gdmconfig.[ch]: Now supports reading configuration values (including "servers" and "server-foo" sections from gdm.conf-custom and then from gdm.conf if not found in the custom file. Now store translated strings in a separate hash since this improves performance. Fix GET_SERVER_DETAILS so it works better and update config can now update server-foo sections via the "xservers/PARMAETERS" key. * gui/gdmsetup.c: Now only writes to the gdm.conf-custom file and isa smart enough to just delete the key if the value will be the same as in the gdm.conf file. Fixed some core dumping issues caused by my change to make gdmsetup use the new gdmconfig functions for getting configuration data from the server. This work cleaned up the code quite a bit. Removed the "--config" option from gdmsetup since this change makes it edit the configuration of the running GDM daemon instead of a program that edits a particular configuration file. * daemon/gdm.h, doc/C/gdm.xml: Updated docs with info about how configuration works nwo. Now sockets protocol info is the same in both documents. * daemon/gdm.c: Fix GET_SERVER_DETAILS to support "ID" and some cleanup. * gui/Makefile.am, daemon/Makefile.am: Support --with-configdir option which got broken. * config/gdm.conf.in: Updated comments to mention that this file is not to be edited. Cleaned up the file so it is more readible. * config/Makefile.am: Install gdm.conf-custom and move gdm.conf to gdm.conf-custom if it is modified and gdm.conf-custom is not already installed. If it is changed and gdm.conf-custom already exists, move it to gdm.conf.org. * gui/gdmchooser.c, gui/gdmflexiserver.c: Remove unused getting of the configuration file. * gui/gdmconfig.[ch]: Add function to tell config to never_cache, which is needed by gdmsetup. * config/gdm.conf-custom: Added template file.
* Now consistantly use "GDM" in strings instead of "gdm". Fixes bug #323221.Brian Cameron2005-12-141-2/+2
| | | | | | | | | | | | | 2005-12-13 Brian Cameron <brian.cameron@sun.com> * daemon/gdm.c, daemon/slave.c, daemon/verify-pam.c, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmsetup.glade, gui/greeter/greeter.c: Now consistantly use "GDM" in strings instead of "gdm". Fixes bug #323221. Thanks to Adam Weinberger <adamw@gnome.org> for pointing this out.
* Remove libgnome dependencies except in gdmflexiserver.c and gdmsetup.c.Brian Cameron2005-12-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-12-12 Brian Cameron <brian.cameron@sun.com> * daemon/misc.c, daemon/server.c, daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c, daemon/xdmcp.c, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmcommon.[ch], gui/gdmdynamic.c, gui/gdmlanguages.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsession.c, gui/gdmuser.c, gui/gdmwm.[ch], gui/greeter/greeter.c, gui/greeter/greeter_action_language.c, gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_item.c, gui/greeter/greeter_item_capslock.c, gui/greeter/greeter_item_pam.c, gui/greeter/greeter_item_timed.c, gui/greeter/greeter_item_ulist.c, gui/greeter/greeter_parser.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c, gui/misc.c, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c, utils/gdm-dmx-reconnect-proxy.c, utils/gdmaskpass.c: Remove libgnome dependencies except in gdmflexiserver.c and gdmsetup.c. Patch provided by Jani Monoses on gdm-list@gnome.org.
* daemon/verify-crypt.c, daemon/verify-pam.c, Convert to using new gdmconfigBrian Cameron2005-11-231-17/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-11-23 Brian Cameron <Brian.Cameron@sun.com> * daemon/verify-crypt.c, daemon/verify-pam.c, Convert to using new gdmconfig interfaces. * daemon/choose.c, daemon/errorgui.c, daemon/gdm.c, daemon/gdmconfig.c, daemon/misc.c, daemon/slave.c, daemon/xdmcp.c, gui/gdmXnestchooser.c, gui/gdmconfig.c, gui/gdmlogin.c, gui/greeter/greeter_canvas_textm.c: Fix compiler warnings. Patch provided by Frederic Crozat on gdm-list@gnome.org. Also make sure that all functions have a space before the "(" to better follow coding style guide. * daemon/cookie.c, daemon/display.c, daemon/gdm-net.c, daemon/getvt.c, daemon/md5.c, daemon/server.c, daemon/verify-pam.c, gui/gdmchooser.c, gui/gdmcommon.c, gui/gdmdynamic.c, gui/gdmlanguages.c, gui/gdmuser.c, gui/greeter/greeter.c, gui/greeter/greeter_action_language.c, gui/greeter/greeter_action_canvas_item.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: Make sure that all functions have a space before the "(" to better follow coding style guide.
* Fix compiler warnings. Fixes bug #322053. Patch provided by FredericBrian Cameron2005-11-221-5/+6
| | | | | | | | | | | | | | 2005-11-22 Brian Cameron <Brian.Cameron@sun.com> * daemon/cookie.c, daemon/gdm.c, daemon/xdmcp.c, gui/gdmchooser.c, gui/greeter/greeter_events.c, gui/greeter/greeter_item_ulist.c, gui/greeter/greeter_parser.[ch], gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c: Fix compiler warnings. Fixes bug #322053. Patch provided by Frederic Crozat. Patch required some work to apply to CVS head.
* This further improves GDM configuration so that now only the GDM daemonBrian Cameron2005-11-221-174/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-11-21 Brian Cameron <Brian.Cameron@sun.com> This further improves GDM configuration so that now only the GDM daemon parses and manages the configuration file. Most client programs use the GET_CONFIG command to access needed data. This simplifies the configuration logic and puts all configuration parsing in one place and gets rid of a lot of global variables that were making the code look messy. This also gets rid of several places where gnome_config deprecated functions were being used. I have cleaned up the code so that the vicious-extensions code is more localized in gui/gdmconfig.[ch]. Some work is left to do: gdmflexiserver still uses gnome_config functions and gdmconfig should use the new functions for reading from the configuration file. Some compile issues fixed as highlghted by dmacks@netspace.org to fix bug #322083. * NEWS: Fixed comment. * daemon/gdm.h: Further cleanup of #define's so that they better match the names of the config keys. * daemon/gdm.c: Now GET_CONFIG returns "OK" if the key is valid but has no value when it is a string. Now free return value from gdm_config_to_string. * daemon/Makefile.am, gui/greeter/Makefile.am: Now the daemon validates the greeter's theme directory, so pass the default value into the daemon and not the greeter. * daemon/gdmconfig.h: Added gdm_is_valid_key and corrected prototype for gdm_set_user_session_lang. * daemon/slave.c: Fix warning and compile errors. * daemon/gdmconfig.c: Further fleshed out. Now it supports a few additional keys I overlooked. It now validates all keys used by the slaves. Now handles translated string. Further refactored the code. * gui/Makefile.am: Added gdmconfig.[ch] to common library. * gui/gdmconfig.[ch]: New functions for accessing configuration data for slaves. * gui/gdmXnestchooser.c, gui/gdmlanguages.c, gui/gdmsession.h, gui/gdmuser.h, gui/gdmwm.c, gui/misc.c, gui/greeter/greeter_item_capslock.c: gui/greeter/greeter_item_pam.c: No longer include vicious.h/viciousui.h, instead gdmconfig.h. * gui/gdmcomm.c: Fix gdm_check_comm to no longer require passing in the config file name. * gui/gdmcommon.[ch]: Get rid of old gdm_common_*_same functions that are replaced with new gui/gdmconfig logic. Now functions that access config data use the new functions. * gui/gdmflexiserver.c: Now displays the localized string when you use GET_CONFIG to access a translatable string. * gui/gdmconfig.c: Now calls update_key in addition to update_greeters when updating greeter config data, since the daemon needs to update the values now when they change. * gui/gdmchooser.c, gui/gdmdynamic.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsession.c, gui/gdmuser.c, gui/gdm/gdmXnestchooser.c, gui/greeter/greeter.c, gui/greeter/greeter_action_language.c, gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_item.c, gui/greeter/greeter_item_customlist.c, gui/greeter/greeter_item_timed.c, gui/greeter/greeter_item_list.c, gui/greeter/greeter_parser.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: Updated to use new configuration functions. * vicious-extensions/glade-helper.c: Now include stdlib.h to avoid compiler warnings. * gui/greeter/greeter.c: Remove unused gdm_kill_thingies function.
* No longer #ifdef the reading of the Multicast config data. It's okay ifBrian Cameron2005-11-081-4/+0
| | | | | | | | | 2005-11-07 Brian Cameron <brian.cameron@sun.com> * daemon/gdm.h, gui/gdmchooser.c: No longer #ifdef the reading of the Multicast config data. It's okay if these values are read in even if IPv6 isn't being used.
* Set the window icon. Use HIG recommended widget spacing.Dennis Cranston2005-11-041-0/+2
| | | | | | | 2005-11-03 Dennis Cranston <dennis_cranston@yahoo.com> * gui/gdmchooser.c: (main): Set the window icon. * gui/gdmchooser.glade: Use HIG recommended widget spacing.
* Redesign of daemon configuraton. Now all vicious-extensions logic is inBrian Cameron2005-11-041-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-11-03 Brian Cameron <brian.cameron@sun.com> Redesign of daemon configuraton. Now all vicious-extensions logic is in gdmconfig.[ch]. This greatly simplifies how the UPDATE_CONFIG, and GET_CONFIG commands work and makes it easier to update the way GDM handles configuration. Changed ve_setenv/ve_unsetenv to g_setenv/g_unsetenv since GDM requires a newer version of GLIB than could possibly cause the old ve versions to get used. * daemon/gdmconfig.[ch]: New logic for interacting with vicious-extensions. * daemon/gdm.h: Updated comments and changed the #define for many configuration options so the naming is more consistant. Now the #defines more closely match the keys in gdm.conf and more consistantly use the underscore. * daemon/auth.c, daemon/choose.c, daemon/cookie.c, daemon/display.c, daemon/errorgui.c, daemon/gdm-net.c, daemon/gdm.c, daemon/getvt.c, daemon/misc.c, daemon/server.c, daemon/slave.c, daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c, daemon/xdmcp.c: Reorganized configuration. * daemon/auth.h, daemon/cookie.h, daemon/display.h, daemon/errorgui.h, daemon/filecheck.h, daemon/gdm-net.h, daemon/getvt.h, daemon/misc.h, daemon/server.h, daemon/slave.h, daemon/verify.h, daemon/xdmcp.h: Now include gdmconfig.h instead of vicious.h and changed "Gnome" to "GNOME" in comment. * daemon/Makefile.am: Added new gdmconfig.[ch] * gui/gdmXnestChooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmdynamic.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.c, gui/greeter/greeter_item_capslock.c, utils/gdm-dmx-reconnect-proxy.c: Updated to reflect the new configuration #defines.
* No longer set tooltips for menu items in gdmlogin. These are distracting,Brian Cameron2005-10-141-52/+17
| | | | | | | | | | | | | | | | | | | | | 2005-10-14 Brian Cameron <Brian.Cameron@sun.com> * gui/gdmlogin.c: No longer set tooltips for menu items in gdmlogin. These are distracting, and do not work with accessibility. After talking with Owen Taylor at the GNOME Boston Summit, he said no GNOME programs do this, and it is not recommended. Fix for bug #144869. * gui/gdmchooser.c: Now use gdm_common_setup_cursor instead of its own copy of the same function. * gui/gdmcommon.[ch]: gdmlogin, gdmgreeter and gdmchooser were all using their own functions to set the background color. Now they use a common function in gdmcommon. * gui/gdmlogin.c, gui/gdmchooser.c, gui/greeter/greeter.c: Now sets background color and sets cursor to a watch as soon as GTK is initialized and the configure file read. This shortens the amount of time the background is Xserver default gray.
* Fix messages. Thanks to Adam Weinberger <adamw@gnome.org> for patches.Brian Cameron2005-09-301-1/+1
| | | | | | | 2005-09-30 Brian Cameron <Brian.Cameron@sun.com> * gui/gdmchooser, gui/gdmcomm.c: Fix messages. Thanks to Adam Weinberger <adamw@gnome.org> for patches.
* Correct memory leaks. Fixes bug #315388, patch by Ray Strode with minorBrian Cameron2005-09-071-35/+48
| | | | | | | | | | | | | | | | 2005-09-06 Brian Cameron <Brian.Cameron@sun.com> * daemon/auth.c, daemon/gdm.c, daemon/slave.c, daemon/verify-pam.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmdynamic.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.c, gui/greeter/greeter_canvas_item.c, gui/greeter/greeter_session.c, gui/modules/keymouselistener.c, utils/gdm-dmx-reconnect-proxy.c, vicious-extensions/vc-misc.c: Correct memory leaks. Fixes bug #315388, patch by Ray Strode with minor tweaks by myself.
* GNOME HIG fixes for the Language, Session and Message dialogs. ModifiedDennis Cranston2005-08-261-24/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-08-20 Dennis Cranston <dennis_cranston@yahoo.com> * gui/gdmXnestchooser.c: (main): * gui/gdmchooser.c: (gdm_chooser_decode_packet), (add_check), (gdm_chooser_add_host), (main): * gui/gdmcomm.c: (gdmcomm_check): * gui/gdmcommon.h: * gui/gdmflexiserver.c: (change_vt), (main): * gui/gdmlogin.c: (back_prog_run), (gdm_login_restart_handler), (gdm_login_halt_handler), (gdm_login_suspend_handler), (gdm_login_session_lookup), (gdm_login_language_lookup), (gdm_login_ctrl_handler), (main): * gui/gdmphotosetup.c: (set_face_from_filename): * gui/gdmsetup.c: (update_greeters), (root_not_allowed), (theme_install_response), (delete_theme), (main): * gui/gdmwm.c: (gdm_common_message), (gdm_common_query), (gdm_common_warn): * gui/greeter/greeter.c: (greeter_ctrl_handler), (verify_gdm_version), (main): * gui/greeter/greeter_action_language.c: (greeter_langauge_initialize_model), (greeter_language_get_language), (greeter_action_language): * gui/greeter/greeter_item_pam.c: (greeter_item_pam_leftover_messages): * gui/greeter/greeter_session.c: (greeter_session_lookup), (greeter_session_init): * gui/greeter/greeter_system.c: (query_greeter_restart_handler), (query_greeter_halt_handler), (query_greeter_suspend_handler): * vicious-extensions/glade-helper.c: (glade_helper_bad_interface), (glade_helper_bad_columns), (glade_helper_no_interface): * vicious-extensions/ve-miscui.c: (ve_hig_dialog_new): * vicious-extensions/ve-miscui.h: GNOME HIG fixes for the Language, Session and Message dialogs. Modified the ve_hig_dialog_new() function to use gtk_message_dialog_new() now that it supports both primary and secondary text. Changed the shutdown, reboot, and suspend dialogs to type GTK_MESSAGE_WARNING.
* Bumped version to 2.8.0.2 since a new interface was added, theBrian Cameron2005-07-231-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * configure.in: Bumped version to 2.8.0.2 since a new interface was added, the gdmflexiserver command, GET_CONFIG_FILE was added. * daemon/Makefile.am, daemon/gdm.[ch], daemon/server.c, daemon/xdmcp.c, docs/C/gdm.xml, gui/Makefile.am, gui/gdmXnestchooser.c, gui/gdmchooser.c, gdm/gdmcomm.[ch], gui/gdmcommon.[ch], gdm/gdmdynamic.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.c: If /etc/gdm/gdm.conf does not exist, then GDM will look in /usr/share/gdm/gdm.conf. Since /usr/share can be shared across multiple systems, this makes it easier for sysadmins to configure sitewide settings for GDM2 instead of having to customize /etc/gdm/gdm.conf on all the machines separately. Now GDM installs the gdm.conf and factory-gdm.conf files in the /usr/share/gdm location. The gdm daemon needs to be restarted to use a different configuration file. All applications that use the config file now use the new GET_CONFIG_FILE gdmflexiserver command to get the configuration file to use. This way the applications don't get confused if, say, the sysadmin creates an /etc/gdm/gdm.conf file after the server was started using one in /usr/share/gdm. Both the gdm daemon and gdmsetup now allow a --config option so the sysadmin can specify their own location for the config file. Moved GdmMulticast and GdmMulticastAddr to gdm.c so we don't access the config file a second time in xdmcp.c. Corrected grammar for some messages. Changed g_access() to access() in gdmphotosetup.c since this is a new 2.7 usntable function. I will change it back when 2.8 is released. * config/Makefile.am: Changed install location of gdm.conf and factory-gdm.conf to %datadir%/gdm ---------------------------------------------------------------------
* Cleanup terminology, and fix many strings. See bug #310453. Also fixes bugTommi Vainikainen2005-07-191-2/+2
| | | | | | | | | | | | | | | | | | 2005-07-19 Tommi Vainikainen <thv@iki.fi> * config/XKeepsCrashing, config/Xsession.in, daemon/display.c, daemon/gdm.c, daemon/slave.c, docs/C/gdm.xml, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/gdmsetup.glade, gui/greeter/greeter.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: Cleanup terminology, and fix many strings. See bug #310453. Also fixes bug #308287. List of the most important string changes: machine -> computer program -> application or command superuser -> root gdm, Gdm -> GDM See the Language chapter in GNOME HIG for more information.
* Change "reboot" to "restart". Changed function names and variables fromBrian Cameron2005-06-021-1/+1
| | | | | | | | | | | | | | 2005-06-02 Brian Cameron <brian.cameron@sun.com> * gui/gdmchooser.c, gui/gdmlogin.c, gui/gdmsetup.glade, gui/greeter/greeter.c, gui/greeter/greeter_system.c: Change "reboot" to "restart". Changed function names and variables from reboot to restart. It's still "reboot_button" in the GDM2 theme XML files since changing this would break backwards compatibility. Fixes bug #305939. Patch for gdmlogin by Nicholas Skehin. I updated the patch so it also applies to gdmgreeter.
* Cleanup for login success/failure sounds. Patch provided by MarkBrian Cameron2005-04-201-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2005-04-19 Brian Cameron <brian.cameron@sun.com> * config/gdm.conf.in, daemon/gdm.[ch], daemon/slave.c, gui/gdmchooser.c, giu/gdmlogin.c: Cleanup for login success/failure sounds. Patch provided by Mark McLoughlin. Refer to bug #300136. * daemon/gdm.c: Fix FlexiServer commands so that all output for a single command is sent as a single call to gdm_connection_write or gdm_connection_printf rather than building commands and sending them out in pieces. Also use gdm_connection_printf rather than building so many temporary strings. Patch provided by for GDM_SUP_QUERY_LOGOUT_ACTION, but I reworked the patch so the same technique is used for all gdmflexiserver commands. Fixes bug #158799. Patch based on one provided by Raffaele Sandrini <rasa@gmx.ch> * gui/greeter/greeter_geometry.c, gui/greeter/greeter_item.h, gui/greeter/greeter_parser.c, docs/C/gdm.xml: Now support ratio scaling of SVG images. Docs weren't provided with the patch so I added some. Patch provided by. Fixes bug 159524. Patch provided by Vincent Untz <vincent@vuntz.net>. * gui/gdmlogin.c: Rearrange how the widgets are organized to make it look a bit better now that the message fields have sizes defined to avoid gdm2 resizing. Bit more of a fix for bug #117779. * README.install: Spell corrections and minor updates, now mention that running configure with the option --with-post-path=/usr/openwin/bin is recommended on Solaris. * MAINTAINERS, AUTHORS, NEWS, docs/C/gdm.xml, daemon/gdm.h: Fixed spelling, added contributors to AUTHORS file for patches made in the past few months. * docs/C/gdm.xml: Fixed bug 300138 by providing better sound docs in the a11y section. Fixes bug #300138. Patch provided by Andrew Case. * gui/gdmsetup.glade, gui/gdmsetup-strings.c: Removed strings "sdfg" and "asdf" since they can't be translated. Fixes bug #301211. * gui/gdmchooser.c: Removed needless comment.
* Add login success/failure sounds. Patch provided by Andrew Case. Refer toBrian Cameron2005-04-191-2/+6
| | | | | | | | | | | | 2005-04-18 Brian Cameron <brian.cameron@sun.com> * daemon/gdm.[ch], daemon/slave.c, docs/C/gdm.xml, gui/gdmchooser.c, gui/gdmcommon.c, gui/gdmlogin.c, gui/gdmsetup-strings.c, gui/gdmsetup.c, gui/gdmsetup.glade, gui/greeter/greeter.c, gui/greeter/greeter_configuration.h: Add login success/failure sounds. Patch provided by Andrew Case. Refer to bug #300136.
* Patched locale.alias to include missing languages. Patch provided by RayBrian Cameron2005-04-121-9/+7
| | | | | | | | | | | | | | | | | | | | 2005-04-11 Brian Cameron <brian.cameron@sun.com> * config/locale.alias: Patched locale.alias to include missing languages. Patch provided by Ray Dassen. * gui/gdmchooser.c: Make button 3 always act like button1 for the chooser as well, further fixes bug #155142. * gui/gdmlogin.c, gui/greeter/greeter.c: Support Control-U for blanking the username/password entry. Fixes bug #103498. Also removed needless ";" from include lines. * gdm/gdmsetup.c: Now clicking "No Logo" or "No background" image causes gdmlogin to update itself immediately. Also fixed "Timed Login" enable checkbox so it takes effect immediately when changed.
* Changed messages so that I-form isn't used. Fixes bug #118193. NoticedBrian Cameron2005-04-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | 2005-04-06 Brian Cameron <brian.cameron@sun.com> * daemon/auth.c, daemon/choose.c, daemon/cookie.c, daemon/display.c, daemon/errorgui.c, daemon/filecheck.c, daemon/gdm-net.c, daemon/gdm.c, daemon/md5.h, daemon/misc.c, daemon/server.c, daemon/slave.c, daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c, daemon/xdmcp.c, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.h, gui/gdmcommon.c, gui/gdmlanguages.c, gui/gdmuser.[ch], gui/gdmwm.c, gui/misc.c, gui/greeter/*.[ch], vicious-extensions/test-ve-config.c, vicious-extensions/ve-i18n.h, vicious-extensions/vicious.h, vicious-extensions/viciousui.h: Changed messages so that I-form isn't used. Fixes bug #118193. Noticed many files didn't have a GPL license as a comment at the top of the file, so added those. Changed "Gnome" to "GNOME" in comments. * gui/gdmlogin.c: Now display timed login message in a separate label, which avoids problems caused because different things (PAM, timed login, etc.) are trying to use the same label for status messages. This fixes bug #67647.
* Fix a number of run-on sentences. Fixes bug 170532.Adam Weinberger2005-03-191-2/+2
| | | | | | | | | | | * daemon/display.c, daemon/gdm.c, daemon/server.c, daemon/slave.c, daemon/verify-crypt.c, daemon/verify-pam.c, daemon/verify-shadow.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmsetup.c, gui/greeter/greeter.c, vicious-extensions/glade-helper.c, vicious-extensions/ve-nongnome.c: Fix a number of run-on sentences. Fixes bug 170532.
* "fix" #148349 by adding French (Belgium), French (Switzerland), GermanGeorge Lebl2004-08-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tue Aug 03 16:29:08 2004 George Lebl <jirka@5z.com> * gui/gdmlanguages.c: "fix" #148349 by adding French (Belgium), French (Switzerland), German (Austria), German (Switzerland) to the translation matrix applying the patch. Patch from Christian Rose * config/locale.alias: add de_AT, de_CH, fr_BE, fr_CH * gui/gdmlanguages.c: normalize english names, patch mostly from Christian Rose, #148350 * gui/gdmlanguages.c: fix #148356 by including a native version of Azerbaijani language name * gui/gdmlanguages.c: fix #148486 by including native name for Gujarati * gui/gdmlanguages.c: fix #148373 by fixing the greek language string * gui/gdmlanguages.c: add en_DK just to have the translation, but don't add it to config/locale.alias * configure.in: fixing #148042 by settings GETTEXT_PACKAGE to gdm * gui/greeter/greeter_system.c: fix #147800 by changing the shortcut for configure from c to g * gui/greeter/greeter.c, gui/greeter/greeter_configuration.c, gui/greeter/greeter_system.c, gui/greeter/greeter_canvas_item.c: Fix #147940 by actually checking if the command exists and not just for NULLs, then disabeling Halt,Suspend or Reboot is really as simple as "RebootCommand=" as it is for gdmlogin * gui/gdmlogin.c, gui/gdmsetup.c, gui/gdmwm.c, gui/gdmcommon.c, gui/gdmchooser.c, gui/greeter/greeter_item.c, gui/greeter/greeter_action_language.c: fix some compiler warnings * daemon/gdm.c: Fix #144076, 144077, the request denied errors that are printed to syslog now just give the request by real name instead of making it look like part of the sentence and so it all makes more sense. * daemon/verify-pam.c: fix some compiler warnings
* on non-local displays, and on displays other then the primary :0 display,George Lebl2004-06-011-0/+18
| | | | | | | | | | | | | Tue Jun 01 11:24:46 2004 George Lebl <jirka@5z.com> * gui/gdmlogin.c, gui/greeter/greeter_item_canvas.c, gui/greeter/greeter.c, gui/gdmchooser.c, gui/gdmcommon.[ch]: on non-local displays, and on displays other then the primary :0 display, disable cursor blinking after 20 seconds of inactivity as it eats bandwidth and cpu for nothing. Should fix #135764 * gui/gdmwm.c: minor cosmetic cleanup
* Apply and heavily massage a patch from Muktha to add font setting to theGeorge Lebl2004-05-061-8/+1
| | | | | | | | | | | | | | | | | | | | Thu May 06 09:59:48 2004 George Lebl <jirka@5z.com> * gui/misc.[ch], gui/gdmlogin.c, gui/gdmsetup.c, gui/gdmchooser.c, gui/greeter/greeter.c: Apply and heavily massage a patch from Muktha to add font setting to the theming and finally fix #125070 hopefully * daemon/misc.c: our gethostent should strip the ::ffff: since it's confusing to rest of gdm and X in particular apparently, so whack it from the hostname so that it doesn't get into the display name. Should fix #133246 * gui/gdmlogin.c, gui/greeter/greeter_item_pam.c: fix #123958 by having an empty message clear the message string rather then append an empty string. Evil, but it fixes the bug. PAM is one large bug in fact, and would require a rather large flywatter to fix, based on a patch from Frederic Crozat
* Fixup the theme changing. Add keys GtkTheme, AllowGtkThemeChange andGeorge Lebl2004-02-121-9/+23
| | | | | | | | | | | | | | | Thu Feb 12 11:49:20 2004 George Lebl <jirka@5z.com> * daemon/display.c, daemon/errorgui.c, daemon/gdm.[ch], daemon/server.c, daemon/slave.c, daemon/xdmcp.c, gui/gdmchooser.c, gui/gdmlogin.c, gui/gdmsetup.c, gui/greeter/greeter.c: Fixup the theme changing. Add keys GtkTheme, AllowGtkThemeChange and GtkThemesToAllow to control this behaviour better. * docs/C/gdm.xml, config/gdm.conf.in: Update for the above changes adding the GtkTheme, AllowGtkThemeChange and GtkThemesToAllow keys
* Wed Feb 11 Muktha <muktha.narayan@wipro.com>Muktha Narayan2004-02-121-0/+8
| | | | | | * daemon/gdm.[ch], daemon/slave.c, gui/gdmlogin.c, gui/gdmchooser.c, gui/gdmsetup.c: Add support for theming. Fixes #125070.
* Fix #125064 by correctly reading out the chooser output and ignoring allGeorge Lebl2004-01-061-20/+27
| | | | | | | | | | | | | | | | | | | Tue Jan 06 11:49:29 2004 George Lebl <jirka@5z.com> * daemon/display.c, daemon/gdm.h, daemon/server.c, daemon/slave.c, daemon/xdmcp.c: Fix #125064 by correctly reading out the chooser output and ignoring all but the last line. * gui/gdmchooser.c: Send a newline BEFORE the chosen host as well as after. Also fix reading the address on hosts that have IPV6, but that don't use it. * gui/greeter/greeter_action_language.c: Get rid of evil 'foo == FALSE' kind of test * gui/modules/Makefile.am, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c: Link with ve so that we can use it and ensure that our BINDIR is in the PATH.
* Added IPv6 supportBalamurali Viswanathan2003-12-091-129/+648
|
* Use the new ve_hig_dialog_new interface to set the markup flag whereGeorge Lebl2003-09-191-0/+4
| | | | | | | | | | | | | | | | Fri Sep 19 15:34:36 2003 George Lebl <jirka@5z.com> * gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.[ch], gui/greeter/greeter_action_language.c, gui/greeter/greeter_item_pam.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: Use the new ve_hig_dialog_new interface to set the markup flag where appropriate fixing #122683 * gui/gdmphotosetup.c, gui/gdmsetup.c: convert filenames to utf8 before displaying them.
* Add some semi randomness spinners which are spun on somewhat randomGeorge Lebl2003-08-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fri Aug 15 12:14:58 2003 George Lebl <jirka@5z.com> * daemon/cookie.[ch], daemon/slave.c, daemon/xdmcp.c, daemon/gdm.c: Add some semi randomness spinners which are spun on somewhat random occasions. This should add to our entropy a bit especially on systems without /dev/random (20 bytes of semi randomness is added this way). And try /dev/srandom on openbsd. * daemon/cookie.c: don't read the buffer max from /dev/random, but only the required size, the (there's no need to md5 512 bytes of truly random data just to get 16 bytes). Require 32 bytes from /dev/random (this is what openssl does apparently), also from openssl, /dev/random still sometimes blocks, so set up a select loop for it that waits 10ms at most. Also try /dev/mem as one of the files in case we can't get enough entropy from /dev/random. * daemon/slave.c: some G_UNLIKELY/G_LIKELY code from yesterday that was still uncommitted * daemon/auth.c: set egid as well as euid when testing for root squashing * gui/gdmXnestchooser.c: add some IGNORE_EINTR * gui/gdmchooser.c: make sure the ARRAY8's are initialized to zero so that we don't possibly crash on bad return packet.
* don't use the paths but let pam find modules itselfGeorge Lebl2003-08-071-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wed Aug 06 17:40:27 2003 George Lebl <jirka@5z.com> * gdmsetup-pam: don't use the paths but let pam find modules itself * gui/gdmlogin.c, gui/greeter/greeter_item_ulist.c: limit number of users at 100 (rather then 50) where it really becomes bad. We need to handle this in a nicer way. * daemon/xdmcp.c: make the globsessid default to rand() so that they really differ from run to run, rather then just time(NULL). check tcp wrappers for managed_forward and got_managed_forward (just to be anal), also check tcp wrappers on forward query, the Alive packet now gets sent with real info rather then just whatever keepalive sent us (and thus follows the spec). Make sure the session id is never zero as that can happen now. Send at most one unwilling packet per second, and try to defer doing any actual work until after we checked with tcp wrappers. Also add some more potential debugging. * daemon/verify-pam.c: translate the lowercase "username:" and "password:", some modules seem to be using those. * daemon/xdmcp.c, gui/gdmchooser.c: if the condition is not new data to be read, don't try to run XdmcpFill * docs/C/gdm.xml: more notes on security of XDMCP and using MIT-MAGIC-COOKIE-1 added, plus a section on the TCP Wrappers, though it kind of sucks.
* minor cleanup of mainGeorge Lebl2003-07-261-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Fri Jul 25 19:01:11 2003 George Lebl <jirka@5z.com> * daemon/gdm.c: minor cleanup of main * daemon/gdm.c, daemon/server.c, daemon/misc.c, daemon/slave.c, gui/gdmlogin.c, gui/greeter/greeter.c, gui/gdmchooser.c: unification of some error messages to make translations simpler, plus fixing bug #56654 finally hopefully by removing programmer references from translatable strings * daemon/slave.c, daemon/misc.[ch], daemon/gdm.c: new functions for ingoring or reseting to DFL of signals using sigaction. In the main daemon ignore SIGPIPE and SIGUSR1, in the slave ignore SIGPIPE and SIGUSR1 and set the mask before the setjmp. also we just unmask some signals now instead of masking everything. * daemon/slave.c: accept DISPLAY_GREETERFAILED from a greeter * gui/gdmlogin.c, gui/greeter/greeter.c: return DISPLAY_GREETERFAILED on bad failures.
* fix build on systems without PIPE_BUF but with _PC_PIPE_BUFGeorge Lebl2003-07-251-4/+15
| | | | | | | Thu Jul 24 17:40:09 2003 George Lebl <jirka@5z.com> * gui/gdmgreeter.c: fix build on systems without PIPE_BUF but with _PC_PIPE_BUF
* change some g_strconcat's to g_build_filename's to address #118040. stillGeorge Lebl2003-07-241-7/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Thu Jul 24 14:58:23 2003 George Lebl <jirka@5z.com> * daemon/gdm.c, daemon/slave.c, daemon/auth.c: change some g_strconcat's to g_build_filename's to address #118040. still more need to be converted * gdm.spec.in, daemon/gdm.h, config/gdm.conf.in, config/Makefile.am, configure.in: By default use logdir of /var/log/gdm just like redhat does it * daemon/gdm.c: check logdir to exist and if not set it to ServAuthDir * gdm.spec.in, daemon/gdm.c, config/Makefile.am: Make the ServAuthDir permissions to be 1770 with owenership root.gdm. That makes it impossible for the gdm user to run DoS attacks against the gdm daemon (though without any process limits set it can still somewhat do that) * daemon/slave.c, daemon/display.c, daemon/gdm.c, daemon/misc.c, daemon/server.c: Hunt more races and hangs. Make sure we really don't do anything bad in signal handlers by making a setjmp at the beginning of the slave_start function and returning there from signal handlers to do final cleanup kind of stuff. Also when we are receiving TERM signals while waiting on stuff to die, be very un-nice to things and SIGKILL them. Also stop using sleep if we might be using alarm at the same time. * daemon/display.c: whack non-useful signal block push on unmanage, and if we get a TERM signal while waiting on the slave, then send a TERM signal to the slave again. * daemon/errorgui.c: set USER, USERNAME and LOGNAME to "gdm" so that they don't end up root by some mistake * daemon/slave.c: Use home of root rather then /root for the home directory of gdmsetup. Also if we can't change to the home directory chdir to / instead of leaving it at servauthdir. Be anal about COOKIEs in the logfile. Also when things go just a bit wrong and not completely whacko, don't ABORT but just REMANAGE, the toplevel loop of death will handle things for us correctly. And setsid a very close to the start of the session to avoid a race ABORTing a display by mistake. * daemon/slave.c: make the PostLogin behave just like PostSession with respect to the return value * daemon/verify-pam.c: avoid races on termination with the verify_cleanup and handle some cases where crashes may (but should not) occur. * daemon/gdm.c: whack unneeded signal blockers (the main daemon is all async with a nice mainloop) * gui/gdmchooser.c: handle HUP gracefully, when one of the config options we care about changes just restart self instead of * gui/gdmlogin.c, gui/greeter/greeter_item_ulist.c: make the username bold * docs/C/gdm.xml: update the PostLogin behaviour and the permissions on the ServAuthDir
* mention the GDM manual in the help dialog box. Connecting to the manual isGeorge Lebl2003-07-201-15/+36
| | | | | | | | | | | | | | | | | | Sun Jul 20 11:01:01 2003 George Lebl <jirka@5z.com> * gui/gdmsetup.c: mention the GDM manual in the help dialog box. Connecting to the manual is a bit harder since this is usually running as root or on the GDM screen * gui/gdmchooser.(c|glade): Fixed most issues from #117784, there is proper keynav, the add button is sensitive only when there is something to add, the messages are shortened a bit to make the interface saner and not have the window change sizes, buttons are reordered, and hostnames in the list are now bold. Also cap status text at max of 256 chars for sanity of display (maybe should be shortened even more). * configure.in: raise version to 2.4.2.98
* Fix #97774 by resetting the rlimits back to infinity after we fork theGeorge Lebl2003-07-151-81/+122
| | | | | | | | | | | | | | | | | | | | | | | Mon Jul 14 16:44:19 2003 George Lebl <jirka@5z.com> * daemon/misc.[ch], daemon/slave.c: Fix #97774 by resetting the rlimits back to infinity after we fork the user session. * config/gdm.conf.in, daemon/gdm.h: The default for AlwaysRestartServer is now again false, since it turns out to be a LOT nicer with buggy X servers (and it turns out quite a lot of people have these). * daemon/slave.c: properly guess the failsafeness of a session and don't re-guess it again * daemon/slave.c: when under the influence of rlimits never ABORT a display since it really could just be that we're hitting stupid limits (definately set way too low). * daemon/slave.c, daemon/server.c, daemon/misc.c: Be extra careful about when to reset signals to avoid races (unlikely though they may be)
* use the ve_ versions of the environment funcs and use ve_config instead ofGeorge Lebl2003-07-111-21/+15
| | | | | | | | | | | | | | | | | | | | | | | Thu Jul 10 17:12:40 2003 George Lebl <jirka@5z.com> * daemon/auth.c, daemon/errorgui.c, daemon/gdm.c, daemon/misc.c, daemon/server.c, daemon/slave.c: use the ve_ versions of the environment funcs and use ve_config instead of gnome_config, and thus killing the libgnome dependency. The ve-config functions are faster, I trust them more, saner in API and definately don't leak any memory to children. * gui/gdmchooser.c, gui/gdmlogin.c, gui/greeter/gui/greeter/greeter_canvas_item.c gui/greeter/greeter_item_capslock.c, gui/greeter/greeter_parser.c: Use the ve_ versions of the environment funcs and ve_config instead of gnome_config, also the use the ve version of the language list function and hand implement the LC_NUMERIC locale push. * configure.in, daemon/Makefile.am, gui/Makefile.am, gui/greeter/Makefile.am: Link against the right ve libs and don't link to libgnome(ui) / glade where not needed
* compile gdmgreeter with viciousui (adds also libgnomeui, though we don'tGeorge Lebl2003-07-081-19/+20
| | | | | | | | | | | | | | | | Mon Jul 07 18:04:21 2003 George Lebl <jirka@5z.com> * configure.in, gui/greeter/Makefile.am: compile gdmgreeter with viciousui (adds also libgnomeui, though we don't use it) (ugh!) * gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/Makefile.am, gui/greeter/greeter.[ch], gui/greeter/greeter_action_language.c, gui/greeter/greeter_item_pam.c, gui/greeter/greeter_session.c, gui/greeter/greeter_system.c: HIGify as many message dialogs as possible. Buttons now make more sense, ordering is HIGgy, and all such good stuff.
* Dialogs have no separators. Makes them look at least a bit closer to HIGGeorge Lebl2003-06-061-0/+5
| | | | | | | | | | | | Fri Jun 06 16:39:17 2003 George Lebl <jirka@5z.com> * daemon/errorgui.c, gui/gdmXnestchooser.c, gui/gdmchooser.c, gui/gdmcomm.c, gui/gdmflexiserver.c, gui/gdmlogin.c, gui/gdmphotosetup.c, gui/gdmsetup.c, gui/greeter/greeter.c, gui/greeter/greeter_action_language.c, gui/greeter/greeter_item_pam.c, gui/modules/dwellmouselistener.c, gui/modules/keymouselistener.c: Dialogs have no separators. Makes them look at least a bit closer to HIG