From 84b4f871e3d8276a102285ac83d21ef11256d6c3 Mon Sep 17 00:00:00 2001 From: Benjamin Berg Date: Fri, 21 Aug 2020 12:15:47 +0200 Subject: manager: Always write out parameter The get_display_and_details_for_bus_sender function does not return a proper error value. Due to this, it makes sense to always write the out parameters (though, I expect we have still more that we might need to write). This is just slightly safer, but the function probably isn't great as is. --- daemon/gdm-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c index e1bc09b1..012be49d 100644 --- a/daemon/gdm-manager.c +++ b/daemon/gdm-manager.c @@ -576,10 +576,11 @@ get_display_and_details_for_bus_sender (GdmManager *self, lookup_by_session_id, (gpointer) session_id); +out: if (out_display != NULL) { *out_display = display; } -out: + g_free (session_id); } -- cgit v1.2.1