From fc6ee4aa6d71d2c448a9b62aca24ba318163c590 Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Tue, 28 Jun 2011 12:51:51 -0400 Subject: common: don't tank on criticals Tiny (or not so tiny) bugs in components below GDM in the stack can lead to critical warnings. In development releases, GDM by default will crash when encountering a critical warning. Losing the login screen is a big deal. We shouldn't automatically subject our users to "can't log in" in order to highlight bugs in development releases. This commit removes fatal criticals by default. --- common/gdm-common.c | 9 --------- common/gdm-common.h | 1 - 2 files changed, 10 deletions(-) (limited to 'common') diff --git a/common/gdm-common.c b/common/gdm-common.c index 7a4e26d8..865341a2 100644 --- a/common/gdm-common.c +++ b/common/gdm-common.c @@ -65,15 +65,6 @@ gdm_is_version_unstable (void) return unstable; } -void -gdm_set_fatal_warnings_if_unstable (void) -{ - if (gdm_is_version_unstable ()) { - g_setenv ("G_DEBUG", "fatal_criticals", FALSE); - g_log_set_always_fatal (G_LOG_LEVEL_CRITICAL); - } -} - gboolean gdm_get_pwent_for_name (const char *name, struct passwd **pwentp) diff --git a/common/gdm-common.h b/common/gdm-common.h index 06300c8f..41ddf1c1 100644 --- a/common/gdm-common.h +++ b/common/gdm-common.h @@ -31,7 +31,6 @@ G_BEGIN_DECLS gboolean gdm_is_version_unstable (void); -void gdm_set_fatal_warnings_if_unstable (void); int gdm_wait_on_pid (int pid); int gdm_wait_on_and_kill_pid (int pid, -- cgit v1.2.1