From 021bf5747b1dfdc77cdb8e2b117e8c9972df681a Mon Sep 17 00:00:00 2001 From: Alessandro Bono Date: Thu, 3 Nov 2022 13:29:06 +0100 Subject: gdm-server: Plug a memory leak identifier was not freed. While at it use g_autofree and simplify how the identifier is created. --- daemon/gdm-server.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'daemon/gdm-server.c') diff --git a/daemon/gdm-server.c b/daemon/gdm-server.c index ebd0a78b..7b73f8e3 100644 --- a/daemon/gdm-server.c +++ b/daemon/gdm-server.c @@ -428,15 +428,9 @@ gdm_server_setup_journal_fds (GdmServer *server) #ifdef ENABLE_SYSTEMD_JOURNAL if (sd_booted () > 0) { int out, err; - const char *prefix = "gdm-Xorg-"; - char *identifier; - gsize size; - - size = strlen (prefix) + strlen (server->display_name) + 1; - identifier = g_alloca (size); - strcpy (identifier, prefix); - strcat (identifier, server->display_name); - identifier[size - 1] = '\0'; + g_autofree char *identifier = NULL; + + identifier = g_strdup_printf("gdm-Xorg-%s", server->display_name); out = sd_journal_stream_fd (identifier, LOG_INFO, FALSE); if (out < 0) -- cgit v1.2.1