From 8fda79cda9b8a89ddcfe3a95436c2b92699d1869 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Thu, 13 Feb 2014 14:48:00 -0500 Subject: session: Prevent memory leaks by removing strdup accessors gdm_session_get_* dup the strings they return, but not a lot of code frees the resulting strings. It's a lot easier to not dup the return values and make them const char *, as they won't ever change while some code holds onto them... --- daemon/gdm-session.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'daemon/gdm-session.h') diff --git a/daemon/gdm-session.h b/daemon/gdm-session.h index 33ff43a7..fb190bf7 100644 --- a/daemon/gdm-session.h +++ b/daemon/gdm-session.h @@ -105,11 +105,11 @@ void gdm_session_start_reauthentication (GdmSession *session, GPid pid_of_caller, uid_t uid_of_caller); -char *gdm_session_get_server_address (GdmSession *session); -char *gdm_session_get_username (GdmSession *session); -char *gdm_session_get_display_device (GdmSession *session); -char *gdm_session_get_display_seat_id (GdmSession *session); -char *gdm_session_get_session_id (GdmSession *session); +const char *gdm_session_get_server_address (GdmSession *session); +const char *gdm_session_get_username (GdmSession *session); +const char *gdm_session_get_display_device (GdmSession *session); +const char *gdm_session_get_display_seat_id (GdmSession *session); +const char *gdm_session_get_session_id (GdmSession *session); gboolean gdm_session_bypasses_xsession (GdmSession *session); void gdm_session_start_conversation (GdmSession *session, -- cgit v1.2.1