From 354715346deed252ef7db53160b61d04bd630a2f Mon Sep 17 00:00:00 2001 From: Julian Smith Date: Fri, 22 Nov 2019 18:08:05 +0000 Subject: Coverity 351049: avoid buffer overflow warning. We're actually safe because gp_fmode_binary_suffix is max one-character long, but Coverity doesn't know that. --- base/gxclfile.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/base/gxclfile.c b/base/gxclfile.c index d2887dd2f..841009a01 100644 --- a/base/gxclfile.c +++ b/base/gxclfile.c @@ -476,8 +476,7 @@ clist_rewind(clist_file_ptr cf, bool discard_data, const char *fname) IFILE *ocf = fake_path_to_file(fname); char fmode[4]; - strcpy(fmode, "w+"); - strcat(fmode, gp_fmode_binary_suffix); + snprintf(fmode, sizeof(fmode), "w+%s", gp_fmode_binary_suffix); if (ocf) { if (discard_data) { -- cgit v1.2.1