summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSorin Sbarnea <ssbarnea@redhat.com>2017-02-23 15:30:14 +0000
committerSorin Sbarnea <ssbarnea@redhat.com>2017-02-23 15:42:51 +0000
commit72175104ddff76282ad36cebecc7397bc74a85a0 (patch)
treec82d59f8d78e8235a2457fbe626d41f2734b6f71
parent67dbbc2e59b0b104c9de0a8ab1d39ca54e9845ca (diff)
downloadgit-review-72175104ddff76282ad36cebecc7397bc74a85a0.tar.gz
Better username detection for add_remote()
Change-Id: Ia083ec9d5f19bff4944080559672b5947d4e43ee
-rwxr-xr-xgit_review/cmd.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/git_review/cmd.py b/git_review/cmd.py
index 597ba22..1cd8290 100755
--- a/git_review/cmd.py
+++ b/git_review/cmd.py
@@ -20,6 +20,7 @@ limitations under the License."""
import argparse
import datetime
+import getpass
import json
import os
import re
@@ -391,9 +392,7 @@ def add_remote(scheme, hostname, port, project, remote, usepushurl):
username = git_config_get_value("gitreview", "username")
if not username:
- username = os.getenv("USERNAME")
- if not username:
- username = os.getenv("USER")
+ username = getpass.getuser()
remote_url = make_remote_url(scheme, username, hostname, port, project)
if VERBOSE: