diff options
| author | Christoph Settgast <christoph.settgast@methodpark.com> | 2017-06-29 10:27:16 +0200 |
|---|---|---|
| committer | Simon Kuhnle <simon.kuhnle@methodpark.de> | 2017-07-25 08:53:48 +0200 |
| commit | b61f5b2ec9ab140960a1c6e0a424389cdd8951a0 (patch) | |
| tree | 1c865eae2344486b68da9aedbf758cc0bcc56094 | |
| parent | 089e8e64b1fcc0b0a2adf9c3f0bd0a8107647278 (diff) | |
| download | git-review-b61f5b2ec9ab140960a1c6e0a424389cdd8951a0.tar.gz | |
Fix listing changes over SSH for 2.14
The SSH query API changed from 2.13 to 2.14 from
{"number":"1", ...}
to
{"number":1, ...}
so we need to stringify everything in order to do len, encode etc. on
it.
Change-Id: I06bdd1b4b1181d00a27ce1e76f97baed8cde1284
Story: 2001095
| -rwxr-xr-x | git_review/cmd.py | 2 | ||||
| -rw-r--r-- | git_review/tests/test_unit.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/git_review/cmd.py b/git_review/cmd.py index 3d02a24..b0956ff 100755 --- a/git_review/cmd.py +++ b/git_review/cmd.py @@ -1028,7 +1028,7 @@ class ReviewsPrinter(object): @property def fields_width(self): return [ - max(len(review[field]) for review in self.reviews) + max(len(str(review[field])) for review in self.reviews) for field in self.fields[:-1] ] + [1] diff --git a/git_review/tests/test_unit.py b/git_review/tests/test_unit.py index 5f77994..4f9fc29 100644 --- a/git_review/tests/test_unit.py +++ b/git_review/tests/test_unit.py @@ -66,7 +66,7 @@ class GitReviewConsole(testtools.TestCase, fixtures.TestWithFixtures): 'subject': 'A simple short subject', 'topic': 'simple-topic' }, { - 'number': '9877', + 'number': 9877, # Starting with 2.14, numbers are sent as int 'branch': 'stable/codeword', 'subject': 'A longer and slightly more wordy subject' }, { |