delta/git.git/contrib/credential/gnome-keyring, branch ss/userdiff-update-csharp-java

contrib/git-credential-gnome-keyring.c: small stylistic cleanups

2013-12-16T17:50:42+00:00

Signed-off-by: John Szakmeister 
Signed-off-by: Junio C Hamano 
Reviewed-by: Felipe Contreras

contrib/git-credential-gnome-keyring.c: support really ancient gnome-keyring

2013-10-16T16:35:33+00:00

The gnome-keyring lib (0.4) distributed with RHEL 4.X is really ancient
and does not provide most of the synchronous functions that even ancient
releases do.  Thankfully, we're only using one function that is missing.
Let's emulate gnome_keyring_item_delete_sync() by calling the asynchronous
function and then triggering the event loop processing until our
callback is called.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: support ancient gnome-keyring

2013-10-16T16:35:33+00:00

The gnome-keyring lib distributed with RHEL 5.X is ancient and does
not provide a few of the functions/defines that more recent versions
do, but mostly the API is the same.  Let's provide the missing bits
via macro definitions and function implementation.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: report failure to store password

2013-10-16T16:35:33+00:00

Produce an error message when we fail to store a password to the keyring.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: use glib messaging functions

2013-10-16T16:35:32+00:00

Rather than roll our own, let's use the messaging functions provided
by glib.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: use glib memory allocation functions

2013-10-16T16:35:32+00:00

Rather than roll our own, let's use the memory allocation/free routines
provided by glib.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: use secure memory for reading passwords

2013-10-16T16:35:32+00:00

gnome-keyring provides functions to allocate non-pageable memory (if
possible).  Let's use them to allocate memory that may be used to hold
secure data read from the keyring.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: use secure memory functions for passwds

2013-10-16T16:35:31+00:00

gnome-keyring provides functions for allocating non-pageable memory (if
possible) intended to be used for storing passwords.  Let's use them.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: use gnome helpers in keyring_object()

2013-10-16T16:35:31+00:00

Rather than carefully allocating memory for sprintf() to write into,
let's make use of the glib helper function g_strdup_printf(), which
makes things a lot easier and less error-prone.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano

contrib/git-credential-gnome-keyring.c: set Gnome application name

2013-10-16T16:35:31+00:00

Since this is a Gnome application, let's set the application name to
something reasonable.  This will be displayed in Gnome dialog boxes
e.g. the one that prompts for the user's keyring password.

We add an include statement for glib.h and add the glib-2.0 cflags and
libs to the compilation arguments, but both of these are really noops
since glib is already a dependency of gnome-keyring.

Signed-off-by: Brandon Casey 
Signed-off-by: Junio C Hamano