diff options
| author | Peter Hagervall <hager@cs.umu.se> | 2005-09-02 14:17:10 +0200 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2005-09-04 10:28:38 -0700 |
| commit | 2ab141a26f93c4d97e243a6be8a38a7dd4eb35a3 (patch) | |
| tree | f5399eb6ab1c1242e0efcb56759288bf8063b773 | |
| parent | baeda3a749ddcb6feee8354cf2b6f8f55cbd7200 (diff) | |
| download | git-2ab141a26f93c4d97e243a6be8a38a7dd4eb35a3.tar.gz | |
[PATCH] Possible cleanups for local-pull.c
Hi. This patch contains the following possible cleanups:
* Make some needlessly global functions in local-pull.c static
* Change 'char *' to 'const char *' where appropriate
Signed-off-by: Peter Hagervall <hager@cs.umu.se>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rw-r--r-- | cache.h | 2 | ||||
| -rw-r--r-- | local-pull.c | 10 | ||||
| -rw-r--r-- | sha1_file.c | 2 |
3 files changed, 7 insertions, 7 deletions
@@ -327,7 +327,7 @@ extern int get_ack(int fd, unsigned char *result_sha1); extern struct ref **get_remote_heads(int in, struct ref **list, int nr_match, char **match); extern struct packed_git *parse_pack_index(unsigned char *sha1); -extern struct packed_git *parse_pack_index_file(unsigned char *sha1, +extern struct packed_git *parse_pack_index_file(const unsigned char *sha1, char *idx_path); extern void prepare_packed_git(void); diff --git a/local-pull.c b/local-pull.c index 8b16f50e33..ca0003ba2a 100644 --- a/local-pull.c +++ b/local-pull.c @@ -17,7 +17,7 @@ void prefetch(unsigned char *sha1) static struct packed_git *packs = NULL; -void setup_index(unsigned char *sha1) +static void setup_index(unsigned char *sha1) { struct packed_git *new_pack; char filename[PATH_MAX]; @@ -30,7 +30,7 @@ void setup_index(unsigned char *sha1) packs = new_pack; } -int setup_indices() +static int setup_indices(void) { DIR *dir; struct dirent *de; @@ -49,7 +49,7 @@ int setup_indices() return 0; } -int copy_file(const char *source, const char *dest, const char *hex) +static int copy_file(const char *source, const char *dest, const char *hex) { if (use_link) { if (!link(source, dest)) { @@ -97,7 +97,7 @@ int copy_file(const char *source, const char *dest, const char *hex) return -1; } -int fetch_pack(unsigned char *sha1) +static int fetch_pack(const unsigned char *sha1) { struct packed_git *target; char filename[PATH_MAX]; @@ -125,7 +125,7 @@ int fetch_pack(unsigned char *sha1) return 0; } -int fetch_file(unsigned char *sha1) +static int fetch_file(const unsigned char *sha1) { static int object_name_start = -1; static char filename[PATH_MAX]; diff --git a/sha1_file.c b/sha1_file.c index fa37f1e3ef..64eac592bb 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -487,7 +487,7 @@ struct packed_git *parse_pack_index(unsigned char *sha1) return parse_pack_index_file(sha1, path); } -struct packed_git *parse_pack_index_file(unsigned char *sha1, char *idx_path) +struct packed_git *parse_pack_index_file(const unsigned char *sha1, char *idx_path) { struct packed_git *p; unsigned long idx_size; |