summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2009-05-28 22:50:23 -0700
committerJunio C Hamano <gitster@pobox.com>2009-05-28 22:50:23 -0700
commita9d29038a7acc0d37f801a2a923826a3539f4ae6 (patch)
treeccf93e0bc010aa8ef831de56bf0b10f4149b19d1
parent3902985a58d5b5f42406f11f1c8b9b87a98c7e3c (diff)
parent6a01554e6350123c78de805d820e90f1c56e5fdc (diff)
downloadgit-a9d29038a7acc0d37f801a2a923826a3539f4ae6.tar.gz
Merge branch 'maint'
* maint: fix segfault showing an empty remote
-rw-r--r--builtin-remote.c8
-rwxr-xr-xt/t5505-remote.sh10
2 files changed, 14 insertions, 4 deletions
diff --git a/builtin-remote.c b/builtin-remote.c
index 71abf68404..fda9a54a0c 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -299,11 +299,11 @@ static int get_push_ref_states(const struct ref *remote_refs,
return 0;
local_refs = get_local_heads();
- ref = push_map = copy_ref_list(remote_refs);
- while (ref->next)
- ref = ref->next;
- push_tail = &ref->next;
+ push_map = copy_ref_list(remote_refs);
+ push_tail = &push_map;
+ while (*push_tail)
+ push_tail = &((*push_tail)->next);
match_refs(local_refs, push_map, &push_tail, remote->push_refspec_nr,
remote->push_refspec, MATCH_REFS_NONE);
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index 5ec668d6d8..e70246b3fb 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -494,5 +494,15 @@ test_expect_success 'remote prune to cause a dangling symref' '
grep "dangling symref" err
'
+test_expect_success 'show empty remote' '
+
+ test_create_repo empty &&
+ git clone empty empty-clone &&
+ (
+ cd empty-clone &&
+ git remote show origin
+ )
+'
+
test_done