diff options
| author | Jeff King <peff@peff.net> | 2008-04-30 00:36:14 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-04-29 22:45:27 -0700 |
| commit | b3bb5f76e6193db102b063187be854ef3842d89b (patch) | |
| tree | d9a153b402e7fbb80c96eedc9f2d2f4cfc9a786c | |
| parent | 861f00e3496fd5cd866a73f11826dfc8822a5195 (diff) | |
| download | git-b3bb5f76e6193db102b063187be854ef3842d89b.tar.gz | |
cvsimport: always pass user data to "system" as a list
This avoids invoking the shell. Not only is it faster, but
it prevents the possibility of interpreting our arguments in
the shell.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | git-cvsimport.perl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-cvsimport.perl b/git-cvsimport.perl index 8093996e25..33777e2785 100755 --- a/git-cvsimport.perl +++ b/git-cvsimport.perl @@ -767,7 +767,7 @@ sub commit { waitpid($pid,0); die "Error running git-commit-tree: $?\n" if $?; - system("git-update-ref $remote/$branch $cid") == 0 + system('git-update-ref', "$remote/$branch", $cid) == 0 or die "Cannot write branch $branch for update: $!\n"; if ($tag) { |