diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2007-07-19 00:43:16 -0400 |
|---|---|---|
| committer | Shawn O. Pearce <spearce@spearce.org> | 2007-07-19 00:43:16 -0400 |
| commit | d36cd968378cd3e509434b1b9f43f1417fdba57e (patch) | |
| tree | ba77a3cc080d2d1df4fb0ed6494a58da8b0b014f | |
| parent | a870ddc0997881d5e73c0ec4562f3521274c5960 (diff) | |
| download | git-d36cd968378cd3e509434b1b9f43f1417fdba57e.tar.gz | |
git-gui: Avoid unnecessary global statements when possible
Running global takes slightly longer than just accessing the variable
via its package name, especially if the variable is just only once in
the procedure, or isn't even used at all in the procedure. So this is
a minor cleanup for some of our commonly invoked procedures.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
| -rwxr-xr-x | git-gui.sh | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/git-gui.sh b/git-gui.sh index 0aabfba6b7..c5ff7c8a83 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -154,12 +154,10 @@ proc gitexec {args} { } proc reponame {} { - global _reponame - return $_reponame + return $::_reponame } proc is_MacOSX {} { - global tcl_platform tk_library if {[tk windowingsystem] eq {aqua}} { return 1 } @@ -167,17 +165,16 @@ proc is_MacOSX {} { } proc is_Windows {} { - global tcl_platform - if {$tcl_platform(platform) eq {windows}} { + if {$::tcl_platform(platform) eq {windows}} { return 1 } return 0 } proc is_Cygwin {} { - global tcl_platform _iscygwin + global _iscygwin if {$_iscygwin eq {}} { - if {$tcl_platform(platform) eq {windows}} { + if {$::tcl_platform(platform) eq {windows}} { if {[catch {set p [exec cygpath --windir]} err]} { set _iscygwin 0 } else { |