diff options
author | Junio C Hamano <gitster@pobox.com> | 2015-10-20 15:22:40 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-10-20 15:22:41 -0700 |
commit | 3b7c49e9a3bbb2c2667465835fe73d623f63601e (patch) | |
tree | ec3f09d82a1474d9ae90e43e6f0ec30ab234b5e6 | |
parent | ce555f38426e212ced5f2445bc6df1351af21cab (diff) | |
parent | b2a7123b997f950e9785a5e7df64c3104270fef3 (diff) | |
download | git-3b7c49e9a3bbb2c2667465835fe73d623f63601e.tar.gz |
Merge branch 'rd/test-path-utils' into maint
The normalize_ceiling_entry() function does not muck with the end
of the path it accepts, and the real world callers do rely on that,
but a test insisted that the function drops a trailing slash.
* rd/test-path-utils:
test-path-utils.c: remove incorrect assumption
-rw-r--r-- | path.c | 5 | ||||
-rw-r--r-- | test-path-utils.c | 2 |
2 files changed, 5 insertions, 2 deletions
@@ -676,6 +676,11 @@ const char *remove_leading_path(const char *in, const char *prefix) * normalized, any time "../" eats up to the prefix_len part, * prefix_len is reduced. In the end prefix_len is the remaining * prefix that has not been overridden by user pathspec. + * + * NEEDSWORK: This function doesn't perform normalization w.r.t. trailing '/'. + * For everything but the root folder itself, the normalized path should not + * end with a '/', then the callers need to be fixed up accordingly. + * */ int normalize_path_copy_len(char *dst, const char *src, int *prefix_len) { diff --git a/test-path-utils.c b/test-path-utils.c index 3dd3744a57..c67bf65b34 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -21,8 +21,6 @@ static int normalize_ceiling_entry(struct string_list_item *item, void *unused) if (normalize_path_copy(buf, ceil) < 0) die("Path \"%s\" could not be normalized", ceil); len = strlen(buf); - if (len > 1 && buf[len-1] == '/') - die("Normalized path \"%s\" ended with slash", buf); free(item->string); item->string = xstrdup(buf); return 1; |