summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Vigier <boklm@mars-attacks.org>2014-02-01 02:18:02 +0000
committerJunio C Hamano <gitster@pobox.com>2014-02-03 12:13:44 -0800
commit2f9dc1fb529662e157c53c7d91e5f75e0f72c6ea (patch)
treec084fe58e7e9a7d29f72a880006db0336d61462e
parent3b4e395f510c0193be06f264ec53271a6baf0414 (diff)
downloadgit-2f9dc1fb529662e157c53c7d91e5f75e0f72c6ea.tar.gz
rebase: remove useless arguments check
Remove a check on the number of arguments for --onto and -x options. It is not possible for $# to be <= 2 at this point : - if --onto or -x has an argument, git rev-parse --parseopt will provide something like this : set -- --onto 'x' -- when parsing the "--onto" option, $# will be 3 or more if there are other options. - if --onto or -x doesn't have an argument, git rev-parse --parseopt will exit with an error and display usage information. Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-rebase.sh2
1 files changed, 0 insertions, 2 deletions
diff --git a/git-rebase.sh b/git-rebase.sh
index c1f98ae5ad..d1835ba58a 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -238,12 +238,10 @@ do
action=${1##--}
;;
--onto)
- test 2 -le "$#" || usage
onto="$2"
shift
;;
-x)
- test 2 -le "$#" || usage
cmd="${cmd}exec $2${LF}"
shift
;;