summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarsten Blees <blees@dcon.de>2014-07-17 17:37:58 +0200
committerJunio C Hamano <gitster@pobox.com>2014-07-21 09:32:49 -0700
commit38d2750126f326c21b06d63e7c21b05d3a6b74f7 (patch)
tree5de0d47a2057c0bd844c356dfbb536df6b23d172
parente96942e821dec273b884fec378cc2a97a7f5d689 (diff)
downloadgit-38d2750126f326c21b06d63e7c21b05d3a6b74f7.tar.gz
Win32: unify environment case-sensitivity
The environment on Windows is case-insensitive. Some environment functions (such as unsetenv and make_augmented_environ) have always used case- sensitive comparisons instead, while others (getenv, putenv, sorting in spawn*) were case-insensitive. Prevent potential inconsistencies by using case-insensitive comparison in lookup_env (used by putenv, unsetenv and make_augmented_environ). Signed-off-by: Karsten Blees <blees@dcon.de> Signed-off-by: Stepan Kasal <kasal@ucw.cz> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--compat/mingw.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/compat/mingw.c b/compat/mingw.c
index f6c7ad7fd8..654bea4828 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1199,8 +1199,7 @@ static int lookup_env(char **env, const char *name, size_t nmln)
int i;
for (i = 0; env[i]; i++) {
- if (0 == strncmp(env[i], name, nmln)
- && '=' == env[i][nmln])
+ if (!strncasecmp(env[i], name, nmln) && '=' == env[i][nmln])
/* matches */
return i;
}