diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2017-03-23 13:05:19 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-03-23 10:02:55 -0700 |
| commit | 4612edc639e8c7c15420960a92efa609e92ab9a7 (patch) | |
| tree | e04af4645d3bfe38cbb06ff663238f8bbe1c4e21 | |
| parent | b643827b9443deadaa5804998116107953f8b42f (diff) | |
| download | git-4612edc639e8c7c15420960a92efa609e92ab9a7.tar.gz | |
tag: remove a TODO item from the test suite
Change the test for "git tag -l" to not have an associated TODO
comment saying that it should return non-zero if there's no tags.
This was added in commit ef5a6fb597 ("Add test-script for git-tag",
2007-06-28) when the tests for "tag" were initially added, but at this
point changing this would be inconsistent with how "git tag" is a
synonym for "git tag -l", and would needlessly break external code
that relies on this porcelain command.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t7004-tag.sh | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh index 3439913488..830eff948e 100755 --- a/t/t7004-tag.sh +++ b/t/t7004-tag.sh @@ -16,7 +16,6 @@ tag_exists () { git show-ref --quiet --verify refs/tags/"$1" } -# todo: git tag -l now returns always zero, when fixed, change this test test_expect_success 'listing all tags in an empty tree should succeed' ' git tag -l && git tag @@ -136,7 +135,6 @@ test_expect_success \ 'listing a tag using a matching pattern should output that tag' \ 'test $(git tag -l mytag) = mytag' -# todo: git tag -l now returns always zero, when fixed, change this test test_expect_success \ 'listing tags using a non-matching pattern should suceed' \ 'git tag -l xxx' |