diff options
| author | Christian Couder <chriscool@tuxfamily.org> | 2017-09-23 19:55:56 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-09-24 16:58:34 +0900 |
| commit | e6b71539dedc13a5737ab97cf54b9f41f94cac24 (patch) | |
| tree | a132180bb800af32efd23ffaa84643bc75e2fa2d | |
| parent | e3d5e1207ea62dca81116a14abef4a537188865d (diff) | |
| download | git-e6b71539dedc13a5737ab97cf54b9f41f94cac24.tar.gz | |
perf/run: add get_var_from_env_or_config()
Add get_var_from_env_or_config() to easily set variables
from a config file if they are defined there and not already set.
This can also set them to a default value if one is provided.
As an example, use this function to set GIT_PERF_REPEAT_COUNT
from the perf.repeatCount config option or from the default
value.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | t/perf/perf-lib.sh | 3 | ||||
| -rwxr-xr-x | t/perf/run | 21 |
2 files changed, 21 insertions, 3 deletions
diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index b50211b259..2f88fc12a9 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -59,9 +59,6 @@ perf_results_dir=$TEST_OUTPUT_DIRECTORY/test-results mkdir -p "$perf_results_dir" rm -f "$perf_results_dir"/$(basename "$0" .sh).subtests -if test -z "$GIT_PERF_REPEAT_COUNT"; then - GIT_PERF_REPEAT_COUNT=3 -fi die_if_build_dir_not_repo () { if ! ( cd "$TEST_DIRECTORY/.." && git rev-parse --build-dir >/dev/null 2>&1 ); then diff --git a/t/perf/run b/t/perf/run index 1e7c2a59e4..41580ac6df 100755 --- a/t/perf/run +++ b/t/perf/run @@ -34,6 +34,7 @@ unpack_git_rev () { (cd "$(git rev-parse --show-cdup)" && git archive --format=tar $rev) | (cd build/$rev && tar x) } + build_git_rev () { rev=$1 for config in config.mak config.mak.autogen config.status @@ -92,6 +93,26 @@ run_dirs () { done } +get_var_from_env_or_config () { + env_var="$1" + conf_var="$2" + # $3 can be set to a default value + + # Do nothing if the env variable is already set + eval "test -z \"\${$env_var+x}\"" || return + + # Check if the variable is in the config file + test -n "$GIT_PERF_CONFIG_FILE" && + conf_value=$(git config -f "$GIT_PERF_CONFIG_FILE" "$conf_var") && + eval "$env_var=\"$conf_value\"" || { + test -n "${3+x}" && + eval "$env_var=\"$3\"" + } +} + +get_var_from_env_or_config "GIT_PERF_REPEAT_COUNT" "perf.repeatCount" 3 +export GIT_PERF_REPEAT_COUNT + GIT_PERF_AGGREGATING_LATER=t export GIT_PERF_AGGREGATING_LATER |