summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2014-12-04 20:32:44 -0500
committerJunio C Hamano <gitster@pobox.com>2014-12-05 11:11:52 -0800
commit69216bf72be2be4f8aa932324b3145d3f395cdc6 (patch)
tree7409436544dd839555ba2238e857625d1ec1a96c
parente5e73ff20b5a750b9622438fd877f4e4a4c3519b (diff)
downloadgit-69216bf72be2be4f8aa932324b3145d3f395cdc6.tar.gz
for_each_reflog_ent_reverse: turn leftover check into assertionjk/for-each-reflog-ent-reverse
Our loop should always process all lines, even if we hit the beginning of the file. We have a conditional after the loop ends to double-check that there is nothing left and to process it. But this should never happen, and is a sign of a logic bug in the loop. Let's turn it into a BUG assertion. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--refs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/refs.c b/refs.c
index 8ed9aee939..a421d43211 100644
--- a/refs.c
+++ b/refs.c
@@ -3136,7 +3136,7 @@ int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn, void
}
if (!ret && sb.len)
- ret = show_one_reflog_ent(&sb, fn, cb_data);
+ die("BUG: reverse reflog parser had leftover data");
fclose(logfp);
strbuf_release(&sb);