diff options
| author | Anders Melchiorsen <mail@cup.kalibalik.dk> | 2008-08-04 12:18:40 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-08-04 21:46:42 -0700 |
| commit | 7d0b18a4da1be9e738293cc13812757ca47ed109 (patch) | |
| tree | 7dd79690ee16d7af1ccf8a9519c59132599bc35a | |
| parent | 611921654ffb854338ab758009a93c70054fab7f (diff) | |
| download | git-7d0b18a4da1be9e738293cc13812757ca47ed109.tar.gz | |
Add output flushing before fork()
This adds fflush(NULL) before fork() in start_command(), to keep
the generic interface safe.
A remaining use of fork() with no flushing is in a comment in
show_tree(). Rewrite that comment to use start_command().
Signed-off-by: Anders Melchiorsen <mail@cup.kalibalik.dk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin-ls-tree.c | 13 | ||||
| -rw-r--r-- | run-command.c | 1 |
2 files changed, 7 insertions, 7 deletions
diff --git a/builtin-ls-tree.c b/builtin-ls-tree.c index d25767a1f7..cb61717685 100644 --- a/builtin-ls-tree.c +++ b/builtin-ls-tree.c @@ -66,17 +66,16 @@ static int show_tree(const unsigned char *sha1, const char *base, int baselen, /* * Maybe we want to have some recursive version here? * - * Something like: + * Something similar to this incomplete example: * if (show_subprojects(base, baselen, pathname)) { - if (fork()) { - chdir(base); - exec ls-tree; - } - waitpid(); + struct child_process ls_tree; + + ls_tree.dir = base; + ls_tree.argv = ls-tree; + start_command(&ls_tree); } * - * ..or similar.. */ type = commit_type; } else if (S_ISDIR(mode)) { diff --git a/run-command.c b/run-command.c index 6af83c526e..bbb9c777e5 100644 --- a/run-command.c +++ b/run-command.c @@ -68,6 +68,7 @@ int start_command(struct child_process *cmd) trace_argv_printf(cmd->argv, "trace: run_command:"); #ifndef __MINGW32__ + fflush(NULL); cmd->pid = fork(); if (!cmd->pid) { if (cmd->no_stdin) |