diff options
| author | Jeff King <peff@peff.net> | 2012-01-09 23:57:33 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2012-01-10 10:10:43 -0800 |
| commit | 8ec6c8d79567a71ca3c6f1ec73eb453d371b1ade (patch) | |
| tree | 642e28c99507b732e200eacf9c5440eec0acbab9 | |
| parent | 1eb10f4091931d6b89ff10edad63ce9c01ed17fd (diff) | |
| download | git-8ec6c8d79567a71ca3c6f1ec73eb453d371b1ade.tar.gz | |
credential-cache: report more daemon connection errors
Originally, this code remained relatively silent when we
failed to connect to the cache. The idea was that it was
simply a cache, and we didn't want to bother the user with
temporary failures (the worst case is that we would simply
ask their password again).
However, if you have a configuration failure or other
problem, it is helpful for the daemon to report those
problems. Git will happily ignore the failed error code, but
the extra information to stderr can help the user diagnose
the problem.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | credential-cache.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/credential-cache.c b/credential-cache.c index b15a9a7449..193301877f 100644 --- a/credential-cache.c +++ b/credential-cache.c @@ -71,10 +71,14 @@ static void do_cache(const char *socket, const char *action, int timeout, die_errno("unable to relay credential"); } - if (send_request(socket, &buf) < 0 && (flags & FLAG_SPAWN)) { - spawn_daemon(socket); - if (send_request(socket, &buf) < 0) + if (send_request(socket, &buf) < 0) { + if (errno != ENOENT) die_errno("unable to connect to cache daemon"); + if (flags & FLAG_SPAWN) { + spawn_daemon(socket); + if (send_request(socket, &buf) < 0) + die_errno("unable to connect to cache daemon"); + } } strbuf_release(&buf); } |