summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Rast <trast@inf.ethz.ch>2013-04-24 15:54:36 +0200
committerJunio C Hamano <gitster@pobox.com>2013-04-24 13:12:51 -0700
commit2d2e3d25595c1bcd2259db5eb7604f196d35949f (patch)
treed83ee4190ee3ca2dd07a7d1d06efabd34147673e
parentabf5f8723cc65c499eb6b65b07bd935f43525b24 (diff)
downloadgit-2d2e3d25595c1bcd2259db5eb7604f196d35949f.tar.gz
remote: check for superfluous arguments in 'git remote add'
The 'git remote add' subcommand did not check for superfluous command line arguments. Make it so. Signed-off-by: Thomas Rast <trast@inf.ethz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/remote.c2
-rwxr-xr-xt/t5505-remote.sh2
2 files changed, 2 insertions, 2 deletions
diff --git a/builtin/remote.c b/builtin/remote.c
index 937484d7c7..5e54d367b8 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -178,7 +178,7 @@ static int add(int argc, const char **argv)
argc = parse_options(argc, argv, NULL, options, builtin_remote_add_usage,
0);
- if (argc < 2)
+ if (argc != 2)
usage_with_options(builtin_remote_add_usage, options);
if (mirror && master)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh
index c23e8482f0..07eb378922 100755
--- a/t/t5505-remote.sh
+++ b/t/t5505-remote.sh
@@ -1020,7 +1020,7 @@ test_extra_arg () {
"
}
-test_extra_arg -f add nick url
+test_extra_arg add nick url
test_extra_arg rename origin newname
test_extra_arg remove origin
test_extra_arg set-head origin master