summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohannes Schindelin <Johannes.Schindelin@gmx.de>2009-01-02 19:07:52 +0100
committerJunio C Hamano <gitster@pobox.com>2009-01-02 13:19:40 -0800
commitcca1704897e7fdb182f68d4c48a437c5d7bc5203 (patch)
tree7ccf394b2e80536442703e0013bf0dde86547e08
parent3827210b91a7d363ea67bcf0b9c6ee1c91d2f3c5 (diff)
downloadgit-cca1704897e7fdb182f68d4c48a437c5d7bc5203.tar.gz
git wrapper: Make while loop more reader-friendly
It is not a good practice to prefer performance over readability in something as performance uncritical as finding the trailing slash of argv[0]. So avoid head-scratching by making the loop user-readable, and not hyper-performance-optimized. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--git.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/git.c b/git.c
index 940a498962..e0d9071358 100644
--- a/git.c
+++ b/git.c
@@ -428,9 +428,8 @@ int main(int argc, const char **argv)
* name, and the dirname as the default exec_path
* if we don't have anything better.
*/
- do
- --slash;
- while (cmd <= slash && !is_dir_sep(*slash));
+ while (cmd <= slash && !is_dir_sep(*slash))
+ slash--;
if (cmd <= slash) {
*slash++ = 0;
git_set_argv0_path(cmd);