diff options
| author | Eric Wong <normalperson@yhbt.net> | 2013-01-24 00:23:44 +0000 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2013-01-24 10:21:23 +0000 |
| commit | 1b67bef25606471817d9b0a61a923568de0daac8 (patch) | |
| tree | 72994628c2f41d976392a036756fead68a4a9dd9 | |
| parent | ec3ae6ec46ed48383ae40643990f169b65a563cc (diff) | |
| download | git-1b67bef25606471817d9b0a61a923568de0daac8.tar.gz | |
git-svn: cleanup sprintf usage for uppercasing hex
We do not need to call uc() separately for sprintf("%x")
as sprintf("%X") is available.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
| -rw-r--r-- | perl/Git/SVN.pm | 4 | ||||
| -rw-r--r-- | perl/Git/SVN/Editor.pm | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm index 59215fa86e..490e330380 100644 --- a/perl/Git/SVN.pm +++ b/perl/Git/SVN.pm @@ -490,7 +490,7 @@ sub refname { # # Additionally, % must be escaped because it is used for escaping # and we want our escaped refname to be reversible - $refname =~ s{([ \%~\^:\?\*\[\t])}{uc sprintf('%%%02x',ord($1))}eg; + $refname =~ s{([ \%~\^:\?\*\[\t])}{sprintf('%%%02X',ord($1))}eg; # no slash-separated component can begin with a dot . # /.* becomes /%2E* @@ -2377,7 +2377,7 @@ sub map_path { sub uri_encode { my ($f) = @_; - $f =~ s#([^a-zA-Z0-9\*!\:_\./\-])#uc sprintf("%%%02x",ord($1))#eg; + $f =~ s#([^a-zA-Z0-9\*!\:_\./\-])#sprintf("%%%02X",ord($1))#eg; $f } diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm index 3db152155c..fa0d3c6cdd 100644 --- a/perl/Git/SVN/Editor.pm +++ b/perl/Git/SVN/Editor.pm @@ -146,7 +146,7 @@ sub url_path { my ($self, $path) = @_; if ($self->{url} =~ m#^https?://#) { # characters are taken from subversion/libsvn_subr/path.c - $path =~ s#([^~a-zA-Z0-9_./!$&'()*+,-])#uc sprintf("%%%02x",ord($1))#eg; + $path =~ s#([^~a-zA-Z0-9_./!$&'()*+,-])#sprintf("%%%02X",ord($1))#eg; } $self->{url} . '/' . $self->repo_path($path); } |