summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-24 14:22:09 -0700
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-04-24 14:22:09 -0700
commitc35dfe858991ee1969870d2da9337a1da567157e (patch)
treec7957a1345ea647b825c3a222d0c7e66cee2c311
parentd32987be618181db1f435a5c0a1bea85e90c7c7d (diff)
downloadgit-c35dfe858991ee1969870d2da9337a1da567157e.tar.gz
Verify that the object type matches for tree/commit objects even before parsing.
The type doesn't come from the parsing, the type also has to match the usage.
-rw-r--r--commit.c2
-rw-r--r--tree.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/commit.c b/commit.c
index c0dd689ea3..c6fdfd4919 100644
--- a/commit.c
+++ b/commit.c
@@ -15,7 +15,7 @@ struct commit *lookup_commit(unsigned char *sha1)
ret->object.type = commit_type;
return ret;
}
- if (obj->parsed && obj->type != commit_type) {
+ if (obj->type != commit_type) {
error("Object %s is a %s, not a commit",
sha1_to_hex(sha1), obj->type);
return NULL;
diff --git a/tree.c b/tree.c
index 23476da7de..3537c11558 100644
--- a/tree.c
+++ b/tree.c
@@ -80,7 +80,7 @@ struct tree *lookup_tree(unsigned char *sha1)
ret->object.type = tree_type;
return ret;
}
- if (obj->parsed && obj->type != tree_type) {
+ if (obj->type != tree_type) {
error("Object %s is a %s, not a tree",
sha1_to_hex(sha1), obj->type);
return NULL;