summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>2018-02-09 18:02:08 +0700
committerJunio C Hamano <gitster@pobox.com>2018-02-09 10:24:52 -0800
commit7a60e3bb830a7e07be23316035a095b7ca36ae27 (patch)
tree3500ca6b8d077806f056ee5513bd3b483c12da02
parentd73a59d12f10079ad404b2992a64dab961930234 (diff)
downloadgit-7a60e3bb830a7e07be23316035a095b7ca36ae27.tar.gz
completion: use __gitcomp_builtin in _git_notes
The new completable options are: --allow-empty (notes add and notes append) --for-rewrite= (notes copy) Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/notes.c4
-rw-r--r--contrib/completion/git-completion.bash14
2 files changed, 10 insertions, 8 deletions
diff --git a/builtin/notes.c b/builtin/notes.c
index b52e71c73e..6990683bd4 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -413,7 +413,7 @@ static int add(int argc, const char **argv, const char *prefix)
parse_reuse_arg},
OPT_BOOL(0, "allow-empty", &allow_empty,
N_("allow storing empty note")),
- OPT__FORCE(&force, N_("replace existing notes"), 0),
+ OPT__FORCE(&force, N_("replace existing notes"), PARSE_OPT_NOCOMPLETE),
OPT_END()
};
@@ -484,7 +484,7 @@ static int copy(int argc, const char **argv, const char *prefix)
struct notes_tree *t;
const char *rewrite_cmd = NULL;
struct option options[] = {
- OPT__FORCE(&force, N_("replace existing notes"), 0),
+ OPT__FORCE(&force, N_("replace existing notes"), PARSE_OPT_NOCOMPLETE),
OPT_BOOL(0, "stdin", &from_stdin, N_("read objects from stdin")),
OPT_STRING(0, "for-rewrite", &rewrite_cmd, N_("command"),
N_("load rewriting config for <command> (implies "
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index c7b8b37f19..60127daebf 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1835,7 +1835,7 @@ _git_notes ()
case "$subcommand,$cur" in
,--*)
- __gitcomp '--ref'
+ __gitcomp_builtin notes
;;
,*)
case "$prev" in
@@ -1851,15 +1851,17 @@ _git_notes ()
add,--reedit-message=*|append,--reedit-message=*)
__git_complete_refs --cur="${cur#*=}"
;;
- add,--*|append,--*)
- __gitcomp '--file= --message= --reedit-message=
- --reuse-message='
+ add,--*)
+ __gitcomp_builtin notes_add
+ ;;
+ append,--*)
+ __gitcomp_builtin notes_append
;;
copy,--*)
- __gitcomp '--stdin'
+ __gitcomp_builtin notes_copy
;;
prune,--*)
- __gitcomp '--dry-run --verbose'
+ __gitcomp_builtin notes_prune
;;
prune,*)
;;