diff options
| author | Michael Haggerty <mhagger@alum.mit.edu> | 2011-09-15 23:10:41 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-10-05 13:45:31 -0700 |
| commit | f989fea0e0b47873de62a355f4766f03a88fb01b (patch) | |
| tree | 6adaf0ef216fcff1b6bdb2c7291b58ed8e9ec917 | |
| parent | 629cd3ac6d081b43c8cdb045845be1fedbc89615 (diff) | |
| download | git-f989fea0e0b47873de62a355f4766f03a88fb01b.tar.gz | |
resolve_ref(): also treat a too-long SHA1 as invalid
If the SHA1 in a reference file is not terminated by a space or
end-of-file, consider it malformed and emit a warning.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | refs.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -593,7 +593,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int * if (flag) *flag |= REF_ISSYMREF; } - if (get_sha1_hex(buffer, sha1)) { + /* Please note that FETCH_HEAD has a second line containing other data. */ + if (get_sha1_hex(buffer, sha1) || (buffer[40] != '\0' && !isspace(buffer[40]))) { warning("reference in %s is formatted incorrectly", path); return NULL; } |