diff options
| author | Ronnie Sahlberg <sahlberg@google.com> | 2014-05-15 10:29:41 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-05-15 14:11:53 -0700 |
| commit | 358ec864cedd0d0b4c5dff6e1fdea1648dbd51ad (patch) | |
| tree | 8d40c319bda490f221944bfc60864a1030b0b64b | |
| parent | 9e70afe421ffb20ec35ff37953b76c41e767b22f (diff) | |
| download | git-358ec864cedd0d0b4c5dff6e1fdea1648dbd51ad.tar.gz | |
fast-import.c: use a ref transaction when dumping tags
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | fast-import.c | 17 |
1 files changed, 12 insertions, 5 deletions
diff --git a/fast-import.c b/fast-import.c index b3c6a04a94..bd73a6de9a 100644 --- a/fast-import.c +++ b/fast-import.c @@ -1731,15 +1731,22 @@ static void dump_tags(void) { static const char *msg = "fast-import"; struct tag *t; - struct ref_lock *lock; char ref_name[PATH_MAX]; + struct strbuf err = STRBUF_INIT; + struct ref_transaction *transaction; + transaction = ref_transaction_begin(); for (t = first_tag; t; t = t->next_tag) { - sprintf(ref_name, "tags/%s", t->name); - lock = lock_ref_sha1(ref_name, NULL); - if (!lock || write_ref_sha1(lock, t->sha1, msg) < 0) - failure |= error("Unable to update %s", ref_name); + sprintf(ref_name, "refs/tags/%s", t->name); + + if (ref_transaction_update(transaction, ref_name, t->sha1, + NULL, 0, 0)) + failure |= error("Unable to update %s", err.buf); } + if (failure || ref_transaction_commit(transaction, msg, &err)) + failure |= error("Unable to update %s", err.buf); + ref_transaction_free(transaction); + strbuf_release(&err); } static void dump_marks_helper(FILE *f, |