diff options
author | Ronnie Sahlberg <sahlberg@google.com> | 2014-04-24 16:36:55 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-06-12 13:39:31 -0700 |
commit | 5e9ebc9751aad7c6b610198b4f670fe61e753f2d (patch) | |
tree | b16c594cd897ca128a80a24870393e249da8d832 | |
parent | b426ce6d4f9a42b9aee24da7c0a1a255d4c4dc91 (diff) | |
download | git-5e9ebc9751aad7c6b610198b4f670fe61e753f2d.tar.gz |
refs.c: change update_ref to use a transaction
Change the update_ref helper function to use a ref transaction internally.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
-rw-r--r-- | refs.c | 25 |
1 files changed, 21 insertions, 4 deletions
@@ -3547,11 +3547,28 @@ int update_ref(const char *action, const char *refname, const unsigned char *sha1, const unsigned char *oldval, int flags, enum action_on_err onerr) { - struct ref_lock *lock; - lock = update_ref_lock(refname, oldval, flags, NULL, onerr); - if (!lock) + struct ref_transaction *t; + struct strbuf err = STRBUF_INIT; + + t = ref_transaction_begin(&err); + if (!t || + ref_transaction_update(t, refname, sha1, oldval, flags, + !!oldval, &err) || + ref_transaction_commit(t, action, &err)) { + const char *str = "update_ref failed for ref '%s': %s"; + + ref_transaction_free(t); + switch (onerr) { + case UPDATE_REFS_MSG_ON_ERR: + error(str, refname, err.buf); break; + case UPDATE_REFS_DIE_ON_ERR: + die(str, refname, err.buf); break; + case UPDATE_REFS_QUIET_ON_ERR: break; + } + strbuf_release(&err); return 1; - return update_ref_write(action, refname, sha1, lock, NULL, onerr); + } + return 0; } static int ref_update_compare(const void *r1, const void *r2) |