summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2017-11-18 11:20:04 +0100
committerJunio C Hamano <gitster@pobox.com>2017-11-18 20:38:40 +0900
commit782c030ea21f02a5dfab3fd023e14084ebeff4dc (patch)
treec8e55101eac5d31163c2ea5fa77ff433fbf20a52
parent3b48045c6c73a51834a2f83440a30225485ee431 (diff)
downloadgit-782c030ea21f02a5dfab3fd023e14084ebeff4dc.tar.gz
config: flip return value of write_section()rs/config-write-section-fix
d9bd4cbb9cc (config: flip return value of store_write_*()) made write_section() follow the convention of write(2) to return -1 on error and the number of written bytes on success. 3b48045c6c7 (Merge branch 'sd/branch-copy') changed it back to returning 0 on error and 1 on success, but left its callers still checking for negative values. Let write_section() follow the convention of write(2) again to meet the expectations of its callers. Reported-by: Jeff King <peff@peff.net> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--config.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/config.c b/config.c
index 4831c12735..201ad36d34 100644
--- a/config.c
+++ b/config.c
@@ -2319,7 +2319,7 @@ static ssize_t write_section(int fd, const char *key)
struct strbuf sb = store_create_section(key);
ssize_t ret;
- ret = write_in_full(fd, sb.buf, sb.len) == sb.len;
+ ret = write_in_full(fd, sb.buf, sb.len);
strbuf_release(&sb);
return ret;