summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSiddharth Kannan <kannan.siddharth12@gmail.com>2017-02-25 07:24:43 +0000
committerJunio C Hamano <gitster@pobox.com>2017-02-27 10:52:20 -0800
commit2481592e35845edd97673212d37c6d2845d0ad72 (patch)
treec7a1ffb5eb86490e7dc1a0f95ae118c933c3202c
parent77efde49797bb7902f0ccd4861839aa48dd67316 (diff)
downloadgit-2481592e35845edd97673212d37c6d2845d0ad72.tar.gz
revision.c: swap if/else blocks
Swap the condition and bodies of an "if (A) do_A else do_B" in setup_revisions() to "if (!A) do_B else do A", to make the change in the the next step easier to read. No behaviour change is intended in this step. Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--revision.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/revision.c b/revision.c
index 5674a9aa27..8d4ddaed9f 100644
--- a/revision.c
+++ b/revision.c
@@ -2238,7 +2238,9 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
}
- if (handle_revision_arg(arg, revs, flags, revarg_opt)) {
+ if (!handle_revision_arg(arg, revs, flags, revarg_opt))
+ got_rev_arg = 1;
+ else {
int j;
if (seen_dashdash || *arg == '^')
die("bad revision '%s'", arg);
@@ -2255,8 +2257,6 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
append_prune_data(&prune_data, argv + i);
break;
}
- else
- got_rev_arg = 1;
}
if (prune_data.nr) {