diff options
| author | Dan McGee <dpmcgee@gmail.com> | 2011-10-18 00:21:21 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-10-18 00:16:31 -0700 |
| commit | be12681896fab9455eb65ea124df423b462e0072 (patch) | |
| tree | 7a4e91fda2ebca5c5b049134152fdf2568d0cad9 | |
| parent | 703f05ad5835cff92b12c29aecf8d724c8c847e2 (diff) | |
| download | git-be12681896fab9455eb65ea124df423b462e0072.tar.gz | |
pack-objects: mark add_to_write_order() as inline
This function is a whole 26 bytes when compiled on x86_64, but is
currently invoked over 1.037 billion times when running pack-objects on
the Linux kernel git repository. This is hitting the point where
micro-optimizations do make a difference, and inlining it only increases
the object file size by 38 bytes.
As reported by perf, this dropped task-clock from 84183 to 83373 ms, and
total cycles from 223.5 billion to 221.6 billion. Not astronomical, but
worth getting for adding one word.
Signed-off-by: Dan McGee <dpmcgee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/pack-objects.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index a9c67c18ba..70b757e792 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -454,7 +454,7 @@ static int mark_tagged(const char *path, const unsigned char *sha1, int flag, return 0; } -static void add_to_write_order(struct object_entry **wo, +static inline void add_to_write_order(struct object_entry **wo, int *endp, struct object_entry *e) { |