diff options
| author | Junio C Hamano <gitster@pobox.com> | 2014-04-30 14:23:26 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-05-02 13:24:57 -0700 |
| commit | dd30800bcd236233c82da80bba0d00956a246260 (patch) | |
| tree | ba38a74663f3cc69f766cda41b089e96d7b09281 /Documentation/CodingGuidelines | |
| parent | 7e76a2f97546444fe7a2af18825450e29c3622a4 (diff) | |
| download | git-dd30800bcd236233c82da80bba0d00956a246260.tar.gz | |
CodingGuidelines: once it is in, it is not worth the code churn
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/CodingGuidelines')
| -rw-r--r-- | Documentation/CodingGuidelines | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index f424dbd75c..c405b0b9df 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -18,6 +18,14 @@ code. For Git in general, three rough rules are: judgement call, the decision based more on real world constraints people face than what the paper standard says. + - Fixing style violations while working on a real change as a + preparatory clean-up step is good, but otherwise avoid useless code + churn for the sake of conforming to the style. + + "Once it _is_ in the tree, it's not really worth the patch noise to + go and fix it up." + Cf. http://article.gmane.org/gmane.linux.kernel/943020 + Make your code readable and sensible, and don't try to be clever. As for more concrete guidelines, just imitate the existing code |