diff options
author | Jeff King <peff@peff.net> | 2013-07-09 20:19:12 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-07-09 22:23:09 -0700 |
commit | eccb614924c9067eeceffa503e4da3683f1c8b6b (patch) | |
tree | 153f2b480f11456aa7678052a02fd975a89218c7 /argv-array.h | |
parent | 4621085b7eb2f4cffe16d508988ff9b4a874b4ef (diff) | |
download | git-eccb614924c9067eeceffa503e4da3683f1c8b6b.tar.gz |
use "sentinel" function attribute for variadic lists
This attribute can help gcc notice when callers forget to
add a NULL sentinel to the end of the function. This is our
first use of the sentinel attribute, but we shouldn't need
to #ifdef for other compilers, as __attribute__ is already a
no-op on non-gcc-compatible compilers.
Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
More-Spots-Found-By: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'argv-array.h')
-rw-r--r-- | argv-array.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/argv-array.h b/argv-array.h index 40248d424c..e8057483af 100644 --- a/argv-array.h +++ b/argv-array.h @@ -15,6 +15,7 @@ void argv_array_init(struct argv_array *); void argv_array_push(struct argv_array *, const char *); __attribute__((format (printf,2,3))) void argv_array_pushf(struct argv_array *, const char *fmt, ...); +__attribute__((sentinel)) void argv_array_pushl(struct argv_array *, ...); void argv_array_pop(struct argv_array *); void argv_array_clear(struct argv_array *); |