diff options
author | brian m. carlson <sandals@crustytoothpaste.net> | 2017-03-26 16:01:24 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-03-26 22:08:21 -0700 |
commit | dc01505f7f272a44b974e622f75bd592debe9dcb (patch) | |
tree | 7aa62babd604067a3d928edfa988391711a36007 /bisect.c | |
parent | 5028bf628c7ebfb85d14ec7dc296b264a1c3bcd3 (diff) | |
download | git-dc01505f7f272a44b974e622f75bd592debe9dcb.tar.gz |
Convert GIT_SHA1_HEXSZ used for allocation to GIT_MAX_HEXSZ
Since we will likely be introducing a new hash function at some point,
and that hash function might be longer than 40 hex characters, use the
constant GIT_MAX_HEXSZ, which is designed to be suitable for
allocations, instead of GIT_SHA1_HEXSZ. This will ease the transition
down the line by distinguishing between places where we need to allocate
memory suitable for the largest hash from those where we need to handle
the current hash.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'bisect.c')
-rw-r--r-- | bisect.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -682,7 +682,7 @@ static int is_expected_rev(const struct object_id *oid) static int bisect_checkout(const unsigned char *bisect_rev, int no_checkout) { - char bisect_rev_hex[GIT_SHA1_HEXSZ + 1]; + char bisect_rev_hex[GIT_MAX_HEXSZ + 1]; memcpy(bisect_rev_hex, sha1_to_hex(bisect_rev), GIT_SHA1_HEXSZ + 1); update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0, UPDATE_REFS_DIE_ON_ERR); |