diff options
| author | Jacopo Notarstefano <jacopo.notarstefano@gmail.com> | 2014-02-28 12:09:04 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-03-05 12:26:51 -0800 |
| commit | 9ef5e2a7223fbabf6a29946c1c120bc2c3c6cf86 (patch) | |
| tree | 12ba558c3f2b650c8b71f15bf6a9c8bff10e2338 /branch.c | |
| parent | 2f93541d88fadd1ff5307d81c2c8921ee3eea058 (diff) | |
| download | git-9ef5e2a7223fbabf6a29946c1c120bc2c3c6cf86.tar.gz | |
branch.c: delete size check of newly tracked branch namesjn/branch-lift-unnecessary-name-length-limit
Since commit 6f084a56 the length of a newly tracked branch name was limited
to 1019 = 1024 - 7 - 7 - 1 characters, a bound derived by having to store
this name in a char[1024] called key with two strings of length at most 7
and a '\0' character.
This was no longer necessary as of commit a9f2c136, which uses a strbuf
(documented in Documentation/technical/api-strbuf.txt) to store this value.
Remove this unneeded check to allow branch names longer than 1019
characters.
Signed-off-by: Jacopo Notarstefano <jacopo.notarstefano@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'branch.c')
| -rw-r--r-- | branch.c | 4 |
1 files changed, 0 insertions, 4 deletions
@@ -114,10 +114,6 @@ static int setup_tracking(const char *new_ref, const char *orig_ref, struct tracking tracking; int config_flags = quiet ? 0 : BRANCH_CONFIG_VERBOSE; - if (strlen(new_ref) > 1024 - 7 - 7 - 1) - return error(_("Tracking not set up: name too long: %s"), - new_ref); - memset(&tracking, 0, sizeof(tracking)); tracking.spec.dst = (char *)orig_ref; if (for_each_remote(find_tracked_branch, &tracking)) |