summaryrefslogtreecommitdiff
path: root/builtin-checkout-index.c
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2007-03-31 23:09:02 -0700
committerJunio C Hamano <junkio@cox.net>2007-04-03 23:44:32 -0700
commit30ca07a249744e57163c02250fca420cea364299 (patch)
tree67cfa219ff2e8e5c293d3f2e7eb475093e354771 /builtin-checkout-index.c
parent89815cab95268e8f0f58142b848ac4cd5e9cbdcb (diff)
downloadgit-30ca07a249744e57163c02250fca420cea364299.tar.gz
_GIT_INDEX_OUTPUT: allow plumbing to output to an alternative index file.
When defined, this allows plumbing commands that update the index (add, apply, checkout-index, merge-recursive, mv, read-tree, rm, update-index, and write-tree) to write their resulting index to an alternative index file while holding a lock to the original index file. With this, git-commit that jumps the index does not have to make an extra copy of the index file, and more importantly, it can do the update while holding the lock on the index. However, I think the interface to let an environment variable specify the output is a mistake, as shown in the documentation. If a curious user has the environment variable set to something other than the file GIT_INDEX_FILE points at, almost everything will break. This should instead be a command line parameter to tell these plumbing commands to write the result in the named file, to prevent stupid mistakes. Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-checkout-index.c')
-rw-r--r--builtin-checkout-index.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/builtin-checkout-index.c b/builtin-checkout-index.c
index afe4b0e452..8460f97b66 100644
--- a/builtin-checkout-index.c
+++ b/builtin-checkout-index.c
@@ -202,10 +202,7 @@ int cmd_checkout_index(int argc, const char **argv, const char *prefix)
if (!strcmp(arg, "-u") || !strcmp(arg, "--index")) {
state.refresh_cache = 1;
if (newfd < 0)
- newfd = hold_lock_file_for_update
- (&lock_file, get_index_file(), 1);
- if (newfd < 0)
- die("cannot open index.lock file.");
+ newfd = hold_locked_index(&lock_file, 1);
continue;
}
if (!strcmp(arg, "-z")) {
@@ -302,7 +299,7 @@ int cmd_checkout_index(int argc, const char **argv, const char *prefix)
if (0 <= newfd &&
(write_cache(newfd, active_cache, active_nr) ||
- close(newfd) || commit_lock_file(&lock_file)))
+ close(newfd) || commit_locked_index(&lock_file)))
die("Unable to write new index file");
return 0;
}