summaryrefslogtreecommitdiff
path: root/builtin-fetch.c
diff options
context:
space:
mode:
authorShawn O. Pearce <spearce@spearce.org>2007-09-14 03:31:21 -0400
committerJunio C Hamano <gitster@pobox.com>2007-09-19 03:22:30 -0700
commit425b1393139d99d89c7a95906686d9b041f2ee3d (patch)
tree929a07ce573bd363eb88bddbef476742b6de7ef6 /builtin-fetch.c
parent7a2bff45937a60d846abf3ccb42015539aedcb40 (diff)
downloadgit-425b1393139d99d89c7a95906686d9b041f2ee3d.tar.gz
Simplify fetch transport API to just one function
Commit walkers need to know the SHA-1 name of any objects they have been asked to fetch while the native pack transport only wants to know the names of the remote refs as the remote side must do the name->SHA-1 translation. Since we only have three fetch implementations and one of them (bundle) doesn't even need the name information we can reduce the code required to perform a fetch by having just one function and passing of the filtered list of refs to be fetched. Each transport can then obtain the information it needs from that ref array to construct its own internal operation state. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Conflicts: transport.c Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-fetch.c')
-rw-r--r--builtin-fetch.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-fetch.c b/builtin-fetch.c
index a041df9faf..f5a2718acc 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -355,7 +355,7 @@ static int do_fetch(struct transport *transport,
no_tags = 1;
if (!transport->ops || !transport->ops->get_refs_list ||
- !(transport->ops->fetch_refs || transport->ops->fetch_objs))
+ !transport->ops->fetch)
die("Don't know how to fetch from %s", transport->url);
/* if not appending, truncate FETCH_HEAD */