diff options
| author | Martin Ågren <martin.agren@gmail.com> | 2017-11-07 21:39:45 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-11-08 11:34:00 +0900 |
| commit | 4da72644b768b0491110a8ba0aa84d32b6bde41c (patch) | |
| tree | be9d8ddc0fc3d78e3d5aa2b80edbf396b7c2b566 /builtin/commit.c | |
| parent | a452d0f4bae99c9acef6f7db75f6f1d922618732 (diff) | |
| download | git-4da72644b768b0491110a8ba0aa84d32b6bde41c.tar.gz | |
reduce_heads: fix memory leaksma/reduce-heads-leakfix
We currently have seven callers of `reduce_heads(foo)`. Six of them do
not use the original list `foo` again, and actually, all six of those
end up leaking it.
Introduce and use `reduce_heads_replace(&foo)` as a leak-free version of
`foo = reduce_heads(foo)` to fix several of these. Fix the remaining
leaks using `free_commit_list()`.
While we're here, document `reduce_heads()` and mark it as `extern`.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
| -rw-r--r-- | builtin/commit.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/commit.c b/builtin/commit.c index d75b3805ea..11c4740185 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -1728,7 +1728,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix) allow_fast_forward = 0; } if (allow_fast_forward) - parents = reduce_heads(parents); + reduce_heads_replace(&parents); } else { if (!reflog_msg) reflog_msg = (whence == FROM_CHERRY_PICK) |