summaryrefslogtreecommitdiff
path: root/builtin/commit.c
diff options
context:
space:
mode:
authorJacob Keller <jacob.keller@gmail.com>2017-04-13 10:12:24 -0700
committerJunio C Hamano <gitster@pobox.com>2017-04-18 18:01:41 -0700
commit2cfe66a8ee57fb3da18c262db8e6df95e263510b (patch)
tree0012929e62af8eee6a24e0795f46333d38a6d72f /builtin/commit.c
parent2e5d6503bdc92260eae9c58b9fd1add7014bb853 (diff)
downloadgit-2cfe66a8ee57fb3da18c262db8e6df95e263510b.tar.gz
ls-files: fix path used when recursing into submodulesjk/ls-files-recurse-submodules-fix
Don't assume that the current working directory is the root of the repository. Correctly generate the path for the recursing child processes by building it from the work_tree() root instead. Otherwise if we run ls-files using --git-dir or --work-tree it will not work correctly as it attempts to change directory into a potentially invalid location. Best case, it doesn't exist and we produce an error. Worst case we cd into the wrong location and unknown behavior occurs. Add a new test which highlights this possibility. Signed-off-by: Jacob Keller <jacob.keller@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions