diff options
| author | Michael J Gruber <git@drmicha.warpmail.net> | 2011-03-07 13:31:39 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-03-09 13:50:54 -0800 |
| commit | 1df2d656cc442dc057e30b6fb130967e5ae19654 (patch) | |
| tree | 6290981baed52c65c997e7e0eb172651d9af26ff /builtin/rev-list.c | |
| parent | 24852d917104e294726c54803d5c9012997506ca (diff) | |
| download | git-1df2d656cc442dc057e30b6fb130967e5ae19654.tar.gz | |
rev-list/log: factor out revision mark generation
Currently, we have identical code for generating revision marks ('<',
'>', '-') in 5 places.
Factor out the code to a single function get_revision_mark() for easier
maintenance and extensibility.
Note that the check for !!revs in graph.c (which gets removed
effectively by this patch) is superfluous.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rev-list.c')
| -rw-r--r-- | builtin/rev-list.c | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/builtin/rev-list.c b/builtin/rev-list.c index ba27d39f97..f458cb7587 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -64,18 +64,8 @@ static void show_commit(struct commit *commit, void *data) if (info->header_prefix) fputs(info->header_prefix, stdout); - if (!revs->graph) { - if (commit->object.flags & BOUNDARY) - putchar('-'); - else if (commit->object.flags & UNINTERESTING) - putchar('^'); - else if (revs->left_right) { - if (commit->object.flags & SYMMETRIC_LEFT) - putchar('<'); - else - putchar('>'); - } - } + if (!revs->graph) + fputs(get_revision_mark(revs, commit), stdout); if (revs->abbrev_commit && revs->abbrev) fputs(find_unique_abbrev(commit->object.sha1, revs->abbrev), stdout); |