diff options
| author | René Scharfe <l.s.r@web.de> | 2018-08-02 21:18:14 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-08-03 08:36:20 -0700 |
| commit | 5f0df44cd79a953c287ccb598896ea7aaa2cc9e3 (patch) | |
| tree | d438018d4b5dec908b60bd46913e36a8e6304ade /builtin/send-pack.c | |
| parent | b8ade4c5766774207e05c8f92e262f8f6835bd3d (diff) | |
| download | git-5f0df44cd79a953c287ccb598896ea7aaa2cc9e3.tar.gz | |
parse-options: automatically infer PARSE_OPT_LITERAL_ARGHELP
Parseopt wraps argument help strings in a pair of angular brackets by
default, to tell users that they need to replace it with an actual
value. This is useful in most cases, because most option arguments
are indeed single values of a certain type. The option
PARSE_OPT_LITERAL_ARGHELP needs to be used in option definitions with
arguments that have multiple parts or are literal strings.
Stop adding these angular brackets if special characters are present,
as they indicate that we don't deal with a simple placeholder. This
simplifies the code a bit and makes defining special options slightly
easier.
Remove the flag PARSE_OPT_LITERAL_ARGHELP in the cases where the new
and more cautious handling suffices.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/send-pack.c')
| -rw-r--r-- | builtin/send-pack.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/builtin/send-pack.c b/builtin/send-pack.c index c8af374dee..a4f7dea115 100644 --- a/builtin/send-pack.c +++ b/builtin/send-pack.c @@ -179,8 +179,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix) { OPTION_CALLBACK, 0, CAS_OPT_NAME, &cas, N_("<refname>:<expect>"), N_("require old value of ref to be at this value"), - PARSE_OPT_OPTARG | PARSE_OPT_LITERAL_ARGHELP, - parseopt_push_cas_option }, + PARSE_OPT_OPTARG, parseopt_push_cas_option }, OPT_END() }; |