diff options
| author | Stefan Beller <stefanbeller@googlemail.com> | 2013-08-03 13:51:18 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-08-05 11:32:17 -0700 |
| commit | 4741edd549decfccc016fa4775b349fe94fdf4e5 (patch) | |
| tree | fc5bfb57bf7065e7ca918dc45265840f54c7c18c /builtin/show-ref.c | |
| parent | e6b722db099f435f21ce72b18f0d61dc3c778f1f (diff) | |
| download | git-4741edd549decfccc016fa4775b349fe94fdf4e5.tar.gz | |
Remove deprecated OPTION_BOOLEAN for parsing arguments
As of b04ba2bb4 OPTION_BOOLEAN was deprecated.
This commit removes all occurrences of OPTION_BOOLEAN.
In b04ba2bb4 Junio suggested to replace it with either
OPTION_SET_INT or OPTION_COUNTUP instead. However a pattern, which
occurred often with the OPTION_BOOLEAN was a hidden boolean parameter.
So I defined OPT_HIDDEN_BOOL as an additional possible parse option
in parse-options.h to make life easy.
The OPT_HIDDEN_BOOL was used in checkout, clone, commit, show-ref.
The only exception, where there was need to fiddle with OPTION_SET_INT
was log and notes. However in these two files there is also a pattern,
so we could think of introducing OPT_NONEG_BOOL.
Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/show-ref.c')
| -rw-r--r-- | builtin/show-ref.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index 87806ad5b0..18680bbaeb 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -169,9 +169,8 @@ static const struct option show_ref_options[] = { OPT_BOOLEAN(0, "heads", &heads_only, N_("only show heads (can be combined with tags)")), OPT_BOOLEAN(0, "verify", &verify, N_("stricter reference checking, " "requires exact ref path")), - { OPTION_BOOLEAN, 'h', NULL, &show_head, NULL, - N_("show the HEAD reference, even if it would be filtered out"), - PARSE_OPT_NOARG | PARSE_OPT_HIDDEN }, + OPT_HIDDEN_BOOL('h', NULL, &show_head, + N_("show the HEAD reference, even if it would be filtered out")), OPT_BOOLEAN(0, "head", &show_head, N_("show the HEAD reference, even if it would be filtered out")), OPT_BOOLEAN('d', "dereference", &deref_tags, |