diff options
| author | Brandon Casey <drafnel@gmail.com> | 2011-10-06 13:22:23 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-10-06 13:54:32 -0700 |
| commit | 0d0ff65cea5424a202510fa4e28a461d36032276 (patch) | |
| tree | 86f4aee1bddefc29d904f176c59a2cc0b4bf03cd /builtin | |
| parent | 040a655116c9755bbf30acd22c34eecb2f502c6d (diff) | |
| download | git-0d0ff65cea5424a202510fa4e28a461d36032276.tar.gz | |
builtin/mv.c: plug miniscule memory leak
The "it" string would not be free'ed if base_name was non-NULL.
Let's free it.
Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/mv.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/builtin/mv.c b/builtin/mv.c index e9d191f056..5efe6c5760 100644 --- a/builtin/mv.c +++ b/builtin/mv.c @@ -29,7 +29,11 @@ static const char **copy_pathspec(const char *prefix, const char **pathspec, to_copy--; if (to_copy != length || base_name) { char *it = xmemdupz(result[i], to_copy); - result[i] = base_name ? xstrdup(basename(it)) : it; + if (base_name) { + result[i] = xstrdup(basename(it)); + free(it); + } else + result[i] = it; } } return get_pathspec(prefix, result); |