diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2011-08-14 10:22:04 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-08-16 10:51:34 -0700 |
| commit | 127f04522292fc62152762405c92d6acca4dbcb5 (patch) | |
| tree | 799a8c1b30f8032e1e7e00c4358ee4c7c8d7b52c /builtin | |
| parent | 86c7bb47c76948bd1240a0db5b8dd88cf9db855d (diff) | |
| download | git-127f04522292fc62152762405c92d6acca4dbcb5.tar.gz | |
revert: plug memory leak in "cherry-pick root commit" codepath
The empty tree passed as common ancestor to merge_trees() when
cherry-picking a parentless commit is allocated on the heap and never
freed. Leaking such a small one-time allocation is not a very big
problem, but now that "git cherry-pick" can cherry-pick multiple
commits it can start to add up.
Avoid the leak by storing the fake tree exactly once in the BSS
section (i.e., use a static). While at it, let's add a test to make
sure cherry-picking multiple parentless commits continues to work.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/revert.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/builtin/revert.c b/builtin/revert.c index 853e9e406c..a26a7c9315 100644 --- a/builtin/revert.c +++ b/builtin/revert.c @@ -273,12 +273,7 @@ static void write_message(struct strbuf *msgbuf, const char *filename) static struct tree *empty_tree(void) { - struct tree *tree = xcalloc(1, sizeof(struct tree)); - - tree->object.parsed = 1; - tree->object.type = OBJ_TREE; - pretend_sha1_file(NULL, 0, OBJ_TREE, tree->object.sha1); - return tree; + return lookup_tree((const unsigned char *)EMPTY_TREE_SHA1_BIN); } static NORETURN void die_dirty_index(const char *me) |