summaryrefslogtreecommitdiff
path: root/commit.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2016-07-19 13:22:22 -0700
committerJunio C Hamano <gitster@pobox.com>2016-07-19 13:22:22 -0700
commit96e08010ee5b9d1dbfbcc8561fa69f972a415a38 (patch)
tree03768d6b32e30959c8c587fcd73ca3c1da8ae275 /commit.c
parentf5236a776f31de2654bca9001aa74ef9fe0819d8 (diff)
parent54307ea7c3ced760ee375483a786ec7180798aed (diff)
downloadgit-96e08010ee5b9d1dbfbcc8561fa69f972a415a38.tar.gz
Merge branch 'jk/printf-format'
Code clean-up to avoid using a variable string that compilers may feel untrustable as printf-style format given to write_file() helper function. * jk/printf-format: commit.c: remove print_commit_list() avoid using sha1_to_hex output as printf format walker: let walker_say take arbitrary formats
Diffstat (limited to 'commit.c')
-rw-r--r--commit.c10
1 files changed, 0 insertions, 10 deletions
diff --git a/commit.c b/commit.c
index 2a90e37519..71a360dad3 100644
--- a/commit.c
+++ b/commit.c
@@ -1622,16 +1622,6 @@ struct commit_list **commit_list_append(struct commit *commit,
return &new->next;
}
-void print_commit_list(struct commit_list *list,
- const char *format_cur,
- const char *format_last)
-{
- for ( ; list; list = list->next) {
- const char *format = list->next ? format_cur : format_last;
- printf(format, oid_to_hex(&list->item->object.oid));
- }
-}
-
const char *find_commit_header(const char *msg, const char *key, size_t *out_len)
{
int key_len = strlen(key);