summaryrefslogtreecommitdiff
path: root/credential.c
diff options
context:
space:
mode:
authorMatthieu Moy <Matthieu.Moy@imag.fr>2016-05-31 15:24:43 +0200
committerJunio C Hamano <gitster@pobox.com>2016-05-31 10:01:51 -0700
commitd615628c354ad2aaf3f3f37b3f84ddcc7c3537c6 (patch)
tree3b25eef0575f5bd674cc209c94dc83eec6b903d7 /credential.c
parentb051c59a00dbe1b2316d10ac95c789de2ad35d18 (diff)
downloadgit-d615628c354ad2aaf3f3f37b3f84ddcc7c3537c6.tar.gz
Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion
The DEVELOPER knob was introduced in 658df95 (add DEVELOPER makefile knob to check for acknowledged warnings, 2016-02-25), and works well when used as "make DEVELOPER=1", and when the configure script was not used. However, the advice given in CodingGuidelines to add DEVELOPER=1 to config.mak does not: config.mak is included after testing for DEVELOPER in the Makefile, and at least GNU Make's manual specifies "Conditional directives are parsed immediately", hence the config.mak declaration is not visible at the time the conditional is evaluated. Also, when using the configure script to generate a config.mak.autogen, the later file contained a "CFLAGS = <flags>" initialization, which overrode the "CFLAGS += -W..." triggered by DEVELOPER. This patch fixes both issues. Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'credential.c')
0 files changed, 0 insertions, 0 deletions